You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "kimyenac (via GitHub)" <gi...@apache.org> on 2026/07/26 09:58:59 UTC

[PR] [ZEPPELIN-6342] Enable the endOfLine option in Prettier and cover tsx files [zeppelin]

kimyenac opened a new pull request, #5347:
URL: https://github.com/apache/zeppelin/pull/5347

   ### What is this PR for?
   
   Two related gaps in the `zeppelin-web-angular` Prettier setup.
   
   `.prettierrc` did not declare `endOfLine`, so the line ending the formatter enforces was never stated in the project's own config. Prettier 3 defaults to `lf` and `.editorconfig` already declares `end_of_line=lf`, so the effective behavior does not change. Declaring it makes `.prettierrc` authoritative instead of dependent on those fallbacks.
   
   React `.tsx` sources were covered by no formatter at all. The `prettier` glob in `lint` and `lint:fix` matched `{ts,js,json,css,html}` only, and `lint:react` runs ESLint alone, so nothing formatted the tsx files under `projects/zeppelin-react`. Adding `tsx` to both globs closes that gap. This PR also includes the resulting `prettier --write` output for the three files that were not formatted, `ImageRenderer.tsx`, `TableVisualization.tsx` and `PublishedParagraph.tsx`. Those changes are formatting only, with no logic change.
   
   `scss` and `less` are deliberately left out. There are no scss files, and `.less` is intentionally listed in `.prettierignore`.
   
   ### What type of PR is it?
   Improvement
   
   ### Todos
   * [x] - Declare `"endOfLine": "lf"` in `.prettierrc`
   * [x] - Add `tsx` to the `lint` and `lint:fix` prettier globs
   * [x] - Apply `prettier --write` to the three unformatted tsx files
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-6342
   
   ### How should this be tested?
   * `cd zeppelin-web-angular && npm run lint` passes, including `prettier --check` over the widened glob. The remaining `member-ordering` warnings are pre-existing and unrelated to this change.
   * `npm run lint:react` passes, and the zeppelin-react vitest suite (14 tests) still passes after the reformat.
   * `prettier --check "**/*.tsx"` on master flags exactly `ImageRenderer.tsx`, `TableVisualization.tsx` and `PublishedParagraph.tsx`, and passes on this branch.
   
   ### Screenshots (if appropriate)
   N/A
   
   ### Questions:
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6342] Enable the endOfLine option in Prettier and cover tsx files [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5347:
URL: https://github.com/apache/zeppelin/pull/5347#issuecomment-5092525489

   Merged into master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6342] Enable the endOfLine option in Prettier and cover tsx files [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee merged PR #5347:
URL: https://github.com/apache/zeppelin/pull/5347


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org