You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "xy2953396112 (via GitHub)" <gi...@apache.org> on 2025/08/30 00:29:55 UTC

[PR] [CELEBORN-2136] Flush the DFS file writer on trim only when the size… [celeborn]

xy2953396112 opened a new pull request, #3458:
URL: https://github.com/apache/celeborn/pull/3458

   … exceeds threshold.
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   Flush the DFS file writer on trim only when the size exceeds threshold.
   
   ### Why are the changes needed?
   
   Optimize the DFS Writer write Large Data Blocks on `trim`.
   
   ### Does this PR introduce _any_ user-facing change?
   
   NO
   
   ### How was this patch tested?
   
   CI & Unit test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2136] Flush the DFS file writer on trim only when the size… [celeborn]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3458:
URL: https://github.com/apache/celeborn/pull/3458#issuecomment-3355311637

   This issue was closed because it has been staled for 10 days with no activity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2136] Flush the DFS file writer on trim only when the size… [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3458:
URL: https://github.com/apache/celeborn/pull/3458#discussion_r2311769732


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -3165,6 +3168,30 @@ object CelebornConf extends Logging {
       .booleanConf
       .createWithDefault(true)
 
+  val WORKER_FLUSH_ON_TRIM_HDFS_THRESHOLD: ConfigEntry[Long] =
+    buildConf("celeborn.worker.flush.on.trim.oss.threshold")
+      .categories("worker")
+      .version("0.6.0")

Review Comment:
   ```suggestion
         .version("0.7.0")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2136] Flush the DFS file writer on trim only when the size… [celeborn]

Posted by "xy2953396112 (via GitHub)" <gi...@apache.org>.
xy2953396112 commented on PR #3458:
URL: https://github.com/apache/celeborn/pull/3458#issuecomment-3238941407

   > @xy2953396112, please run command `UPDATE=1 mvn clean test -pl common -am -Dtest=none -DwildcardSuites=org.apache.celeborn.ConfigurationSuite` to update configuration document. BTW, does this PR introduce any user-facing change? You should update description for new configurations.
   
   I have updated the new configurations. Thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2136] Flush the DFS file writer on trim only when the size… [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3458:
URL: https://github.com/apache/celeborn/pull/3458#discussion_r2311769688


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -3165,6 +3168,30 @@ object CelebornConf extends Logging {
       .booleanConf
       .createWithDefault(true)
 
+  val WORKER_FLUSH_ON_TRIM_HDFS_THRESHOLD: ConfigEntry[Long] =
+    buildConf("celeborn.worker.flush.on.trim.oss.threshold")

Review Comment:
   ```suggestion
       buildConf("celeborn.worker.flush.on.trim.hdfs.threshold")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2136] Flush the DFS file writer on trim only when the size… [celeborn]

Posted by "xy2953396112 (via GitHub)" <gi...@apache.org>.
xy2953396112 commented on code in PR #3458:
URL: https://github.com/apache/celeborn/pull/3458#discussion_r2311778862


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -857,9 +859,27 @@ final private[worker] class StorageManager(conf: CelebornConf, workerSource: Abs
         flushOnMemoryPressure(writers)
       }
     })
-    flushOnMemoryPressure(hdfsWriters)
-    flushOnMemoryPressure(s3Writers)
-    flushOnMemoryPressure(ossWriters)
+    if (hdfsWriters.size() > 0) {

Review Comment:
   PTAL.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2136] Flush the DFS file writer on trim only when the size… [celeborn]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3458: [CELEBORN-2136] Flush the DFS file writer on trim only when the size…
URL: https://github.com/apache/celeborn/pull/3458


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2136] Flush the DFS file writer on trim only when the size… [celeborn]

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #3458:
URL: https://github.com/apache/celeborn/pull/3458#issuecomment-3241257725

   Just so you know, this PR is not appropriate. If there is memory pressure, the highest priority is to resolve the memory pressure; however, this PR might slow down or block memory block release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2136] Flush the DFS file writer on trim only when the size… [celeborn]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3458:
URL: https://github.com/apache/celeborn/pull/3458#issuecomment-3315749341

   This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2136] Flush the DFS file writer on trim only when the size… [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3458:
URL: https://github.com/apache/celeborn/pull/3458#discussion_r2311769904


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -857,9 +859,27 @@ final private[worker] class StorageManager(conf: CelebornConf, workerSource: Abs
         flushOnMemoryPressure(writers)
       }
     })
-    flushOnMemoryPressure(hdfsWriters)
-    flushOnMemoryPressure(s3Writers)
-    flushOnMemoryPressure(ossWriters)
+    if (hdfsWriters.size() > 0) {

Review Comment:
   Could you extract common codes to a method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org