You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/06/07 02:30:14 UTC

[GitHub] [submarine] featherchen commented on a change in pull request #597: SUBMARINE-822. Expand log_model for more package

featherchen commented on a change in pull request #597:
URL: https://github.com/apache/submarine/pull/597#discussion_r646234917



##########
File path: submarine-sdk/pysubmarine/tests/models/test_model.py
##########
@@ -54,7 +63,7 @@ def test_update_model(self, mocker):
     def test_load_model(self, mocker):
         mock_method = mocker.patch.object(mlflow.pyfunc, "load_model")
         mock_method.return_value = mlflow.pytorch._PyTorchWrapper(
-            LinearNNModel())
+            LinearNNModelTorch())

Review comment:
       In this PR,I only deal with log_model function.By finitshed the expansion of this funtion,I think it will be easier to deal with other funtion(ex load_model) either in the same way or in Qlib's way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org