[jira] [Commented] (YARN-2988) Graph#save() may leak resource

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257544#comment-14257544 ] 

Hadoop QA commented on YARN-2988:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12688913/YARN-2988-001.patch
  against trunk revision 5caebba.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6178//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6178//console

This message is automatically generated.

> Graph#save() may leak resource
> ------------------------------
>
>                 Key: YARN-2988
>                 URL: https://issues.apache.org/jira/browse/YARN-2988
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: YARN-2988-001.patch
>
>
> In hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/Graph.java :
> {code}
>   public void save(String filepath) throws IOException {
>     OutputStreamWriter fout = new OutputStreamWriter(
>         new FileOutputStream(filepath), Charset.forName("UTF-8"));
>     fout.write(generateGraphViz());
>     fout.close();
> {code}
> The close of fout should be enclosed in finally clause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)