You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/03/21 19:35:15 UTC

[GitHub] [knox] lmccay opened a new pull request #299: KNOX-2307 - CSVKnoxShellTableBuilder must support quoted strings and …

lmccay opened a new pull request #299: KNOX-2307 - CSVKnoxShellTableBuilder must support quoted strings and …
URL: https://github.com/apache/knox/pull/299
 
 
   …embedded commas
   
   Change-Id: I3d2e0dc8144e79c73df2067a7b6320e5d0a84266
   
   (It is very **important** that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!)
   
   ## What changes were proposed in this pull request?
   
   Embedded commas within a quoted string/col in CSV files result in separate cols currently. This patch allows for them to be ignored during the split() call via regex for identifying such patterns.
   
   ## How was this patch tested?
   
   New unit test added and existing unit tests run.
   Manually tested with dataset with such embedded commas in quoted strings.
   
   Please review [Knox Contributing Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow) before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] lmccay commented on issue #299: KNOX-2307 - CSVKnoxShellTableBuilder must support quoted strings and …

Posted by GitBox <gi...@apache.org>.

lmccay commented on issue #299: KNOX-2307 - CSVKnoxShellTableBuilder must support quoted strings and …
URL: https://github.com/apache/knox/pull/299#issuecomment-602112910
 
 
   Fixed to not rely on changes from PR #296 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [knox] lmccay closed pull request #299: KNOX-2307 - CSVKnoxShellTableBuilder must support quoted strings and …

Posted by GitBox <gi...@apache.org>.

lmccay closed pull request #299: KNOX-2307 - CSVKnoxShellTableBuilder must support quoted strings and …
URL: https://github.com/apache/knox/pull/299
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services