[GitHub] [flink] dianfu commented on a diff in pull request #19896: [FLINK-27932][python] align noWatermarks and withWatermarkAlignment API

[GitBox <gi...@apache.org>]

dianfu commented on code in PR #19896:
URL: https://github.com/apache/flink/pull/19896#discussion_r896402211


##########
docs/content.zh/docs/dev/datastream/event-time/generating_watermarks.md:
##########
@@ -77,6 +77,19 @@ WatermarkStrategy
   })
 ```
 {{< /tab >}}
+{{< tab "Python" >}}

Review Comment:
   Could we also update the following page: https://nightlies.apache.org/flink/flink-docs-master/docs/dev/datastream/event-time/built_in/



##########
docs/content.zh/docs/dev/datastream/event-time/generating_watermarks.md:
##########
@@ -136,6 +149,26 @@ withTimestampsAndWatermarks
         .addSink(...)
 ```
 {{< /tab >}}
+{{< tab "Python" >}}
+```python
+env = StreamExecutionEnvironment.get_execution_environment()
+
+# currently read_file is not supported in PyFlink

Review Comment:
   Could we create a ticket for this missing functionality?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org