You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/10/20 05:34:28 UTC

[GitHub] [activemq-artemis] nbrendah opened a new pull request #3805: Artemis-2561: Journal timeout should be configurable

nbrendah opened a new pull request #3805:
URL: https://github.com/apache/activemq-artemis/pull/3805


   Issue Link:  https://issues.apache.org/jira/browse/ARTEMIS-2561
   
   Hi @clebertsuconic 
   This is how i have tried to understand the description and the link to ARTEMIS-2561.
   
   If i am on the right truck, however, i cant find-out the best place to write test cases for this enhancement 
   
   Thank you so much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] nbrendah commented on pull request #3805: Artemis-2561: Journal timeout should be configurable

Posted by GitBox <gi...@apache.org>.
nbrendah commented on pull request #3805:
URL: https://github.com/apache/activemq-artemis/pull/3805#issuecomment-964137943


   Hello @clebertsuconic 
   
   > you need to change the broker.xsd, the parser, the initialization of the broker, the journal, to then pass the parameter to where you added here.
   
   I have read read this couple of times.  The explanations makes sense but implimentation is still in abstract to my minds.  Maybe its because i am not so conversant with this code base.  
   
   At the same time, i dont want to be some other pain, asking questions that seam obvious.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3805: Artemis-2561: Journal timeout should be configurable

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3805:
URL: https://github.com/apache/activemq-artemis/pull/3805#issuecomment-948935668


   @nbrendah the timeout should be configured all the way up to the broker.xml
   
   you need to change the broker.xsd, the parser, the initialization of the broker, the journal, to then pass the parameter to where you added here.
   
   There are a couple of layers between this and the initialization...
   
   it's a simple task in terms of algorithm (there's not much algorithm associated, but you need to understand the initialization of the broker and the parsing of the XML).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] nbrendah commented on pull request #3805: Artemis-2561: Journal timeout should be configurable

Posted by GitBox <gi...@apache.org>.
nbrendah commented on pull request #3805:
URL: https://github.com/apache/activemq-artemis/pull/3805#issuecomment-966439901


   Hello @clebertsuconic,  I have added some changes.  I kindly request for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] nbrendah edited a comment on pull request #3805: Artemis-2561: Journal timeout should be configurable

Posted by GitBox <gi...@apache.org>.
nbrendah edited a comment on pull request #3805:
URL: https://github.com/apache/activemq-artemis/pull/3805#issuecomment-966439901


   Hello @clebertsuconic  @jbertram!  
   I have added some changes.  I kindly request for review.
   Thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org