You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by vo...@apache.org on 2020/06/11 21:38:25 UTC

[fineract] branch develop updated: FINERACT-821 Added and Enforced AnnotationLocation(1) Checkstyle

This is an automated email from the ASF dual-hosted git repository.

vorburger pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new 99c667a  FINERACT-821 Added and Enforced AnnotationLocation(1) Checkstyle
99c667a is described below

commit 99c667ab1ae5569d77cd8cc9d47a0910dcf9d8fd
Author: thesmallstar <ma...@gmail.com>
AuthorDate: Thu Jun 11 05:00:08 2020 +0530

    FINERACT-821 Added and Enforced AnnotationLocation(1) Checkstyle
---
 fineract-provider/config/checkstyle/checkstyle.xml             | 10 ++++------
 .../org/apache/fineract/portfolio/client/domain/Client.java    |  2 +-
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/fineract-provider/config/checkstyle/checkstyle.xml b/fineract-provider/config/checkstyle/checkstyle.xml
index 85e00d7..7cda316 100644
--- a/fineract-provider/config/checkstyle/checkstyle.xml
+++ b/fineract-provider/config/checkstyle/checkstyle.xml
@@ -96,6 +96,10 @@
             <message key="name.invalidPattern"
              value="Package name ''{0}'' must match pattern ''{1}''."/>
         </module>
+            <module name="AnnotationLocation">
+            <property name="tokens" value="VARIABLE_DEF"/>
+            <property name="allowSamelineMultipleAnnotations" value="true"/>
+        </module>
          <module name="AvoidEscapedUnicodeCharacters">
             <property name="allowEscapesForControlCharacters" value="true"/>
             <property name="allowByTailComment" value="true"/>
@@ -238,12 +242,6 @@
             <property name="tokens" value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "/>
         </module>
 
-        <module name="AnnotationLocation">
-            <property name="tokens" value="VARIABLE_DEF"/>
-            <property name="allowSamelineMultipleAnnotations" value="true"/>
-        </module>
-
-
         <! - - Enable some JavaDoc validation (requires quite a lot of manual clean up work; not a top priority for initial Checkstyle adoption - ->
         <module name="JavadocTagContinuationIndentation"/>
         <module name="SummaryJavadocCheck">
diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java
index b9ca944..20fc64b 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java
@@ -231,7 +231,7 @@ public final class Client extends AbstractPersistableCustom {
     private AppUser reopenedBy;
 
     @Column(name = "proposed_transfer_date", nullable = true)
-     @Temporal(TemporalType.DATE)
+    @Temporal(TemporalType.DATE)
      private Date proposedTransferDate;
 
     public static Client createNew(final AppUser currentUser, final Office clientOffice, final Group clientParentGroup, final Staff staff,