[GitHub] rabbah commented on a change in pull request #2658: Treat a timed out active ack as failed activation in invokerhealth protocol

[gi...@git.apache.org]

rabbah commented on a change in pull request #2658: Treat a timed out active ack as failed activation in invokerhealth protocol
URL: https://github.com/apache/incubator-openwhisk/pull/2658#discussion_r137787021
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
 ##########
 @@ -222,11 +228,8 @@ class LoadBalancerService(
         val raw = new String(bytes, StandardCharsets.UTF_8)
         CompletionMessage.parse(raw) match {
             case Success(m: CompletionMessage) =>
-                processCompletion(m.response, m.transid, false)
-                // treat left as success (as it is the result a the message exceeding the bus limit)
-                val isSuccess = m.response.fold(l => true, r => !r.response.isWhiskError)
+                processCompletion(m.response, m.transid, false, m.invoker)
 
 Review comment:
   s/false/forced = false/
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services