You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/01/21 19:47:25 UTC

[GitHub] [trafficcontrol] mitchell852 opened a new issue #5453: API Crud'r framework creates poor change log message on delete

mitchell852 opened a new issue #5453:
URL: https://github.com/apache/trafficcontrol/issues/5453


   ## I'm submitting a ...
   -  improvement request (usability, performance, tech debt, etc.)
   
   ## Traffic Control components affected ...
   -  Traffic Ops
   
   ## Current behavior:
   Deleting a resource via the API that uses the CRUDr framework produces a poor change log message:
   
   ![image](https://user-images.githubusercontent.com/251272/105403440-ff12e980-5be5-11eb-8876-94aee93c9888.png)
   
   ## New behavior:
   Instead of showing ID three times, include name at a minimum in the change log message and if name doesn't exist on the resource, then i guess show id 3 times. :)
   
   ## Minimal reproduction of the problem with instructions:
   Delete something via the API that uses the CRUDr framework (i.e. delete a cdn) and observe the poor and redundant change log message created.
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
       https://apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp commented on issue #5453: API Crud'r framework creates poor change log message on delete

Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #5453:
URL: https://github.com/apache/trafficcontrol/issues/5453#issuecomment-764976915


   Indeed. In the CRUDer I think we could try to type-assert the `Deleter` into a `Reader` and reuse the object's `Read()` method if so.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp commented on issue #5453: API Crud'r framework creates poor change log message on delete

Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #5453:
URL: https://github.com/apache/trafficcontrol/issues/5453#issuecomment-764976915


   Indeed. In the CRUDer I think we could try to type-assert the `Deleter` into a `Reader` and reuse the object's `Read()` method if so.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org