You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "desaikomal (via GitHub)" <gi...@apache.org> on 2023/05/14 15:45:14 UTC

[GitHub] [helix] desaikomal opened a new issue, #2485: TestDistributedControllerManager is using Deprecated ClusterStateVerifier

desaikomal opened a new issue, #2485:
URL: https://github.com/apache/helix/issues/2485

   ### Describe the bug
   We are using the deprecated ClusterStateVerifier tool in the test TestDistributedControllerManager. The test is valid but needs to use the newer replacement class, BestPossibleExternalViewVerifier.
   
   
   ### To Reproduce
   Here is the link to the code:
   https://github.com/apache/helix/blob/master/helix-core/src/test/java/org/apache/helix/integration/manager/TestDistributedControllerManager.java
   and here is the verifier class which has the comment that it has been deprecated:
   
   /**
    * This class is deprecated, please use dedicated verifier classes, such as
    * BestPossibleExternalViewVerifier, etc, in tools.ClusterVerifiers.
    */
   @Deprecated
   public class ClusterStateVerifier {
   
   Here is the link to the code:
   https://github.com/apache/helix/blob/master/helix-core/src/main/java/org/apache/helix/tools/ClusterStateVerifier.java#L79
   
   
   ### Expected behavior
   A clear and concise description of what you expected to happen.
   
   ### Additional context
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] xyuanlu closed issue #2485: TestDistributedControllerManager is using Deprecated ClusterStateVerifier

Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu closed issue #2485: TestDistributedControllerManager is using Deprecated ClusterStateVerifier
URL: https://github.com/apache/helix/issues/2485


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org