[GitHub] [camel] orpiske commented on a diff in pull request #10821: CAMEL-19651: camel-kafka - Use default partitioning logic as the default

["orpiske (via GitHub)" <gi...@apache.org>]

orpiske commented on code in PR #10821:
URL: https://github.com/apache/camel/pull/10821#discussion_r1273652060


##########
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConstants.java:
##########
@@ -61,7 +61,7 @@ public final class KafkaConstants {
 
     public static final String KAFKA_DEFAULT_SERIALIZER = "org.apache.kafka.common.serialization.StringSerializer";
     public static final String KAFKA_DEFAULT_DESERIALIZER = "org.apache.kafka.common.serialization.StringDeserializer";
-    public static final String KAFKA_DEFAULT_PARTITIONER = "org.apache.kafka.clients.producer.internals.DefaultPartitioner";
+    public static final String KAFKA_DEFAULT_PARTITIONER = "";

Review Comment:
   +1 to remove it. 
   
   Just, please, beware that there are a couple of tests referring to this constant. They will need to be adjusted accordingly. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org