You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/06/13 11:05:13 UTC
[GitHub] [incubator-pekko-grpc] pjfanning opened a new pull request, #91: compile issue - now that we support Scala 3
pjfanning opened a new pull request, #91:
URL: https://github.com/apache/incubator-pekko-grpc/pull/91
This implicit without a type declaration is causing major CI build problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning merged pull request #91: compile issue - now that we support Scala 3
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #91:
URL: https://github.com/apache/incubator-pekko-grpc/pull/91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] He-Pin commented on a diff in pull request #91: compile issue - now that we support Scala 3
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #91:
URL: https://github.com/apache/incubator-pekko-grpc/pull/91#discussion_r1228013399
##########
plugin-tester-scala/src/test/scala/example/myapp/helloworld/ErrorReportingSpec.scala:
##########
@@ -37,7 +37,7 @@ import scala.concurrent.duration._
@RunWith(classOf[JUnitRunner])
class ErrorReportingSpec extends AnyWordSpec with Matchers with ScalaFutures with BeforeAndAfterAll {
- override implicit val patienceConfig = PatienceConfig(5.seconds, Span(100, org.scalatest.time.Millis))
+ override implicit val patienceConfig: PatienceConfig = PatienceConfig(5.seconds, Span(100, org.scalatest.time.Millis))
Review Comment:
Maybe add a final too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #91: compile issue - now that we support Scala 3
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #91:
URL: https://github.com/apache/incubator-pekko-grpc/pull/91#discussion_r1228017899
##########
plugin-tester-scala/src/test/scala/example/myapp/helloworld/ErrorReportingSpec.scala:
##########
@@ -37,7 +37,7 @@ import scala.concurrent.duration._
@RunWith(classOf[JUnitRunner])
class ErrorReportingSpec extends AnyWordSpec with Matchers with ScalaFutures with BeforeAndAfterAll {
- override implicit val patienceConfig = PatienceConfig(5.seconds, Span(100, org.scalatest.time.Millis))
+ override implicit val patienceConfig: PatienceConfig = PatienceConfig(5.seconds, Span(100, org.scalatest.time.Millis))
Review Comment:
this is test code and there are dozens of entries like this in the tests - none are final - if we don't like existing code patterns, they can be changed - but in their own PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org