[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

[GitBox <gi...@apache.org>]

gaodayue commented on a change in pull request #1633: add zone map page(#1390)
URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r314975281
 
 

 ##########
 File path: be/src/olap/iterators.h
 ##########
 @@ -35,15 +36,19 @@ struct StorageReadOptions {
 
     // If include_lower_bound is true, data equal with lower_bound will
     // be read
-    bool include_lower_bound;
+    bool include_lower_bound = false;
 
     // upper_bound defines the extend upto which the iterator can return
     // data.
     std::shared_ptr<RowCursor> upper_bound;
 
     // If include_upper_bound is true, data equal with upper_bound will
     // be read
-    bool include_upper_bound;
+    bool include_upper_bound = false;
+
+    // reader's column predicates
+    // used to filter data by zone map/bloom filter/second index
+    std::shared_ptr<Conditions> conditions;
 
 Review comment:
   It's counter-intuitive for me that `StorageReadOptions` participates in the lifecycle management of `Conditions`. Is there any specific reason for it? If not,  just use `Conditions*`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org