[GitHub] [druid] paul-rogers opened a new pull request, #13898: Fix Maven dependencies

["paul-rogers (via GitHub)" <gi...@apache.org>]

paul-rogers opened a new pull request, #13898:
URL: https://github.com/apache/druid/pull/13898

   Static checks include a check of Maven dependencies: `dependency:analyze`. A recent PR had a build fail due to dependency issues. When fixing that, it was discovered that a great many modules have issues when the dependency checker is run as:
   
   ```bash
   mvn dependency:analyze -P skip-tests -Dmaven.javadoc.skip=true -Dcyclonedx.skip=true -DfailOnWarning=true
   ```
   
   It is unclear why the static checks run in GHA did not report these errors.
   
   This PR fixes the issues that arose when running the command. In some cases, the tool gets confused: it tells me that a dependency is declared, but not used. If I remove it, I'm told it is used, but not declared. In these cases, I had to configure the tool to ignore certain dependencies.
   
   With these changes, both the `dependency:analyze` and full build passes. This PR will tell us if the tests also pass.
   
   #### Release note
   
   No user-visible changes.
   
   <hr>
   
   This PR has:
   
   - [X] been self-reviewed.
   - [X] a release note entry in the PR description.
   - [X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] paul-rogers closed pull request #13898: Fix Maven dependencies

["paul-rogers (via GitHub)" <gi...@apache.org>]

paul-rogers closed pull request #13898: Fix Maven dependencies
URL: https://github.com/apache/druid/pull/13898


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org