You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/03/13 04:08:30 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #40389: [SPARK-42767][CONNECT][TESTS] Add check condition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
LuciferYang opened a new pull request, #40389:
URL: https://github.com/apache/spark/pull/40389
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #40389:
URL: https://github.com/apache/spark/pull/40389#discussion_r1135218114
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -49,6 +51,12 @@ object IntegrationTestUtils {
// scalastyle:on println
private[connect] def debug(error: Throwable): Unit = if (isDebug) error.printStackTrace()
+ private[sql] lazy val sparkHiveJarAvailable: Boolean = {
Review Comment:
```suggestion
private[sql] lazy val isSparkHiveJarAvailable: Boolean = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #40389:
URL: https://github.com/apache/spark/pull/40389#issuecomment-1469820687
> Should we push forward this one? @HyukjinKwon
Should, I run test on local, can't passed because I build without hive. And the 2.4.0 release can't build passed without hive.
This is mail list which others find problem. https://lists.apache.org/thread/11kdt36n6ytx87klcp2gd678lddqoknd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #40389:
URL: https://github.com/apache/spark/pull/40389#discussion_r1135384027
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -49,6 +51,12 @@ object IntegrationTestUtils {
// scalastyle:on println
private[connect] def debug(error: Throwable): Unit = if (isDebug) error.printStackTrace()
+ private[sql] lazy val sparkHiveJarAvailable: Boolean = {
+ val filePath = s"$sparkHome/assembly/target/$scalaDir/jars/" +
+ s"spark-hive_$scalaVersion-${org.apache.spark.SPARK_VERSION}.jar"
Review Comment:
🆗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40389:
URL: https://github.com/apache/spark/pull/40389#discussion_r1135297547
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -49,6 +51,12 @@ object IntegrationTestUtils {
// scalastyle:on println
private[connect] def debug(error: Throwable): Unit = if (isDebug) error.printStackTrace()
+ private[sql] lazy val sparkHiveJarAvailable: Boolean = {
+ val filePath = s"$sparkHome/assembly/target/$scalaDir/jars/" +
+ s"spark-hive_$scalaVersion-${org.apache.spark.SPARK_VERSION}.jar"
Review Comment:
@HyukjinKwon It is not ok to try to get the hive-related class on the client side(like `Utils.classIsLoadable("org.apache.hadoop.hive.conf.HiveConf")`), the result should always be false.
`SimpleSparkConnectService` can find `spark-hive_**.jar` in classpath because of the following code:
https://github.com/apache/spark/blob/93334e295483a0ba66e22d8398512ad970a3ea80/bin/spark-class#L39-L51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40389:
URL: https://github.com/apache/spark/pull/40389#discussion_r1135319463
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -49,6 +51,12 @@ object IntegrationTestUtils {
// scalastyle:on println
private[connect] def debug(error: Throwable): Unit = if (isDebug) error.printStackTrace()
+ private[sql] lazy val sparkHiveJarAvailable: Boolean = {
+ val filePath = s"$sparkHome/assembly/target/$scalaDir/jars/" +
+ s"spark-hive_$scalaVersion-${org.apache.spark.SPARK_VERSION}.jar"
Review Comment:
I manually verified the SBT. As I said above, if the code is changed to
```
private[sql] lazy val sparkHiveJarAvailable: Boolean = {
Utils.classIsLoadable("org.apache.hadoop.hive.conf.HiveConf")
}
```
Both
`build/sbt clean "connect-client-jvm/test"`
and
`build/sbt clean "connect-client-jvm/test" -Phive`
will submit `SimpleSparkConnectService ` with `spark.sql.catalogImplementation=in-memory`
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -49,6 +51,12 @@ object IntegrationTestUtils {
// scalastyle:on println
private[connect] def debug(error: Throwable): Unit = if (isDebug) error.printStackTrace()
+ private[sql] lazy val sparkHiveJarAvailable: Boolean = {
+ val filePath = s"$sparkHome/assembly/target/$scalaDir/jars/" +
+ s"spark-hive_$scalaVersion-${org.apache.spark.SPARK_VERSION}.jar"
Review Comment:
I manually checked SBT. As I said above, if the code is changed to
```
private[sql] lazy val sparkHiveJarAvailable: Boolean = {
Utils.classIsLoadable("org.apache.hadoop.hive.conf.HiveConf")
}
```
Both
`build/sbt clean "connect-client-jvm/test"`
and
`build/sbt clean "connect-client-jvm/test" -Phive`
will submit `SimpleSparkConnectService ` with `spark.sql.catalogImplementation=in-memory`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40389:
URL: https://github.com/apache/spark/pull/40389#issuecomment-1469850098
BTW, mind fxing https://github.com/apache/spark/pull/40389#discussion_r1136914961 though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40389:
URL: https://github.com/apache/spark/pull/40389#issuecomment-1471270622
Merged to master and branch-3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
URL: https://github.com/apache/spark/pull/40389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #40389:
URL: https://github.com/apache/spark/pull/40389#discussion_r1135217517
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -49,6 +51,12 @@ object IntegrationTestUtils {
// scalastyle:on println
private[connect] def debug(error: Throwable): Unit = if (isDebug) error.printStackTrace()
+ private[sql] lazy val sparkHiveJarAvailable: Boolean = {
+ val filePath = s"$sparkHome/assembly/target/$scalaDir/jars/" +
+ s"spark-hive_$scalaVersion-${org.apache.spark.SPARK_VERSION}.jar"
Review Comment:
Does this cover SBT build too? I think it would be easier if you just try to get a class (e.g., `org.apache.hadoop.hive.conf.HiveConf`) and see if it fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40389:
URL: https://github.com/apache/spark/pull/40389#discussion_r1135230873
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -49,6 +51,12 @@ object IntegrationTestUtils {
// scalastyle:on println
private[connect] def debug(error: Throwable): Unit = if (isDebug) error.printStackTrace()
+ private[sql] lazy val sparkHiveJarAvailable: Boolean = {
+ val filePath = s"$sparkHome/assembly/target/$scalaDir/jars/" +
+ s"spark-hive_$scalaVersion-${org.apache.spark.SPARK_VERSION}.jar"
Review Comment:
like `Utils.classIsLoadable("org.apache.hadoop.hive.conf.HiveConf")` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40389:
URL: https://github.com/apache/spark/pull/40389#discussion_r1135255889
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -49,6 +51,12 @@ object IntegrationTestUtils {
// scalastyle:on println
private[connect] def debug(error: Throwable): Unit = if (isDebug) error.printStackTrace()
+ private[sql] lazy val sparkHiveJarAvailable: Boolean = {
+ val filePath = s"$sparkHome/assembly/target/$scalaDir/jars/" +
+ s"spark-hive_$scalaVersion-${org.apache.spark.SPARK_VERSION}.jar"
Review Comment:
> Does this cover SBT build too? I think it would be easier if you just try to get a class (e.g., `org.apache.hadoop.hive.conf.HiveConf`) and see if it fails.
Let me think about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40389:
URL: https://github.com/apache/spark/pull/40389#issuecomment-1469847935
> > Should we push forward this one? @HyukjinKwon
>
> Should, I run test on local, can't passed because I build without hive. And the 2.4.0 release can't build passed without hive. This is mail list which others find problem. https://lists.apache.org/thread/11kdt36n6ytx87klcp2gd678lddqoknd
Yes, it will be slightly friendly to developers with this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40389:
URL: https://github.com/apache/spark/pull/40389#issuecomment-1471275097
Thanks @HyukjinKwon and @Hisoka-X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bjornjorgensen commented on pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #40389:
URL: https://github.com/apache/spark/pull/40389#issuecomment-1472688553
@LuciferYang Thank you. Should we update https://github.com/apache/spark/blob/master/docs/building-spark.md with this info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40389:
URL: https://github.com/apache/spark/pull/40389#discussion_r1136922602
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -49,6 +51,12 @@ object IntegrationTestUtils {
// scalastyle:on println
private[connect] def debug(error: Throwable): Unit = if (isDebug) error.printStackTrace()
+ private[sql] lazy val sparkHiveJarAvailable: Boolean = {
Review Comment:
done, I thought I changed yesterday ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40389: [SPARK-42767][CONNECT][TESTS] Add check condition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40389:
URL: https://github.com/apache/spark/pull/40389#issuecomment-1465482691
Will update pr description later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40389:
URL: https://github.com/apache/spark/pull/40389#issuecomment-1469396942
Should we push forward this one? @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40389:
URL: https://github.com/apache/spark/pull/40389#issuecomment-1469844012
cc @grundprinzip and @hvanhovell FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40389:
URL: https://github.com/apache/spark/pull/40389#discussion_r1135297547
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -49,6 +51,12 @@ object IntegrationTestUtils {
// scalastyle:on println
private[connect] def debug(error: Throwable): Unit = if (isDebug) error.printStackTrace()
+ private[sql] lazy val sparkHiveJarAvailable: Boolean = {
+ val filePath = s"$sparkHome/assembly/target/$scalaDir/jars/" +
+ s"spark-hive_$scalaVersion-${org.apache.spark.SPARK_VERSION}.jar"
Review Comment:
@HyukjinKwon It is not ok to try to get the hive-related class on the client side(like `Utils.classIsLoadable("org.apache.hadoop.hive.conf.HiveConf")`), the result should always be false.
`SimpleSparkConnectService` can find `spark-hive_**.jar` in classpath because of the following code:
https://github.com/apache/spark/blob/93334e295483a0ba66e22d8398512ad970a3ea80/bin/spark-class#L39-L51
But the connect client itself does not trigger the above behavior, so the client will not see the hive-related classes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40389:
URL: https://github.com/apache/spark/pull/40389#issuecomment-1473017525
> @LuciferYang Thank you. Should we update https://github.com/apache/spark/blob/master/docs/building-spark.md with this info?
If needed, it may be more appropriate to update in https://github.com/apache/spark/blob/master/connector/connect/README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40389:
URL: https://github.com/apache/spark/pull/40389#discussion_r1135219475
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -49,6 +51,12 @@ object IntegrationTestUtils {
// scalastyle:on println
private[connect] def debug(error: Throwable): Unit = if (isDebug) error.printStackTrace()
+ private[sql] lazy val sparkHiveJarAvailable: Boolean = {
+ val filePath = s"$sparkHome/assembly/target/$scalaDir/jars/" +
+ s"spark-hive_$scalaVersion-${org.apache.spark.SPARK_VERSION}.jar"
Review Comment:
Yes, cover SBT to
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -49,6 +51,12 @@ object IntegrationTestUtils {
// scalastyle:on println
private[connect] def debug(error: Throwable): Unit = if (isDebug) error.printStackTrace()
+ private[sql] lazy val sparkHiveJarAvailable: Boolean = {
+ val filePath = s"$sparkHome/assembly/target/$scalaDir/jars/" +
+ s"spark-hive_$scalaVersion-${org.apache.spark.SPARK_VERSION}.jar"
Review Comment:
Yes, cover SBT too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40389: [SPARK-42767][CONNECT][TESTS] Add a precondition to start connect server fallback with `in-memory` and auto ignored some tests strongly depend on hive
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #40389:
URL: https://github.com/apache/spark/pull/40389#discussion_r1136914961
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/IntegrationTestUtils.scala:
##########
@@ -49,6 +51,12 @@ object IntegrationTestUtils {
// scalastyle:on println
private[connect] def debug(error: Throwable): Unit = if (isDebug) error.printStackTrace()
+ private[sql] lazy val sparkHiveJarAvailable: Boolean = {
Review Comment:
Can we fix this though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org