You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/03/16 11:43:13 UTC
[GitHub] [maven-release] elharo opened a new pull request, #176: improve dependency declarations
elharo opened a new pull request, #176:
URL: https://github.com/apache/maven-release/pull/176
More accurately declare the dependencies of this plugins. This removes some — not all — of the dependency analyzer warnings in the build. Some of the warnings are false positives and perhaps require improvements to the dependency analyzer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #176: improve dependency declarations
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #176:
URL: https://github.com/apache/maven-release/pull/176#issuecomment-1473853359
I will try to review this after SCM release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #176: improve dependency declarations
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #176:
URL: https://github.com/apache/maven-release/pull/176#discussion_r1140384907
##########
maven-release-manager/pom.xml:
##########
@@ -161,6 +161,19 @@
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest-core</artifactId>
+ <version>1.3</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.sonatype.sisu</groupId>
+ <artifactId>sisu-guice</artifactId>
+ <version>3.2.3</version>
+ <classifier>no_aop</classifier>
+ <scope>test</scope>
Review Comment:
I left this one out since the actual dep is in provided scope and it does not matter at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] asfgit closed pull request #176: improve dependency declarations
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #176: improve dependency declarations
URL: https://github.com/apache/maven-release/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] elharo commented on pull request #176: improve dependency declarations
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #176:
URL: https://github.com/apache/maven-release/pull/176#issuecomment-1472110029
I just copied what dependency analyzer claimed we were already using. If it should be a different one, then we definitely need to declare it. (or maybe this is a bug in dependency analyzer and it's not correctly analyzing?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #176: improve dependency declarations
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #176:
URL: https://github.com/apache/maven-release/pull/176#discussion_r1138589995
##########
maven-release-manager/pom.xml:
##########
@@ -161,6 +161,19 @@
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest-core</artifactId>
+ <version>1.3</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.sonatype.sisu</groupId>
+ <artifactId>sisu-guice</artifactId>
+ <version>3.2.3</version>
+ <classifier>no_aop</classifier>
+ <scope>test</scope>
Review Comment:
Really this or the Guice from Google. This is a fork, no? @cstamas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org