You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Adriaan Joubert (JIRA)" <de...@tapestry.apache.org> on 2008/03/05 11:27:41 UTC

[jira] Created: (TAPESTRY-2236) Strip of _ suffix in class transformation

Strip of _ suffix in class transformation
-----------------------------------------

                 Key: TAPESTRY-2236
                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2236
             Project: Tapestry
          Issue Type: Improvement
         Environment: Tapestry 5.0.11-SNAPSHOT
            Reporter: Adriaan Joubert


Hi,

our convention is to use an _ suffix for fields, rather than a prefix. Tapestry cannot naturally transform these field names where needed. Could you please change 

org.apache.tapestry.ioc.internal.util.InternalUtils.stripMemberPrefix(String memberName)

to strip an _ suffix as well. The following addition should do the job

       while (builder.length>0)
        {
            char ch = builder.charAt(builder.length-1);

            if (InternalUtils.NAME_PREFIX.indexOf(ch) < 0) break;

            builder.deleteCharAt(builder.length-1);
        }

Cheers,

Adriaan


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-2236) Strip trailing punctuation (_ and $) from member names, as is done with leading punctuation

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAPESTRY-2236:
-------------------------------------------

    Summary: Strip trailing punctuation (_ and $) from member names, as is done with leading punctuation  (was: Strip of _ suffix in class transformation)

> Strip trailing punctuation (_ and $) from member names, as is done with leading punctuation
> -------------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-2236
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2236
>             Project: Tapestry
>          Issue Type: Improvement
>    Affects Versions: 5.0
>         Environment: Tapestry 5.0.11-SNAPSHOT
>            Reporter: Adriaan Joubert
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.0.15
>
>
> Hi,
> our convention is to use an _ suffix for fields, rather than a prefix. Tapestry cannot naturally transform these field names where needed. Could you please change 
> org.apache.tapestry.ioc.internal.util.InternalUtils.stripMemberPrefix(String memberName)
> to strip an _ suffix as well. The following addition should do the job
>        while (builder.length>0)
>         {
>             char ch = builder.charAt(builder.length-1);
>             if (InternalUtils.NAME_PREFIX.indexOf(ch) < 0) break;
>             builder.deleteCharAt(builder.length-1);
>         }
> Cheers,
> Adriaan

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Closed: (TAPESTRY-2236) Strip trailing punctuation (_ and $) from member names, as is done with leading punctuation

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAPESTRY-2236.
------------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0.15

> Strip trailing punctuation (_ and $) from member names, as is done with leading punctuation
> -------------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-2236
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2236
>             Project: Tapestry
>          Issue Type: Improvement
>    Affects Versions: 5.0
>         Environment: Tapestry 5.0.11-SNAPSHOT
>            Reporter: Adriaan Joubert
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.0.15
>
>
> Hi,
> our convention is to use an _ suffix for fields, rather than a prefix. Tapestry cannot naturally transform these field names where needed. Could you please change 
> org.apache.tapestry.ioc.internal.util.InternalUtils.stripMemberPrefix(String memberName)
> to strip an _ suffix as well. The following addition should do the job
>        while (builder.length>0)
>         {
>             char ch = builder.charAt(builder.length-1);
>             if (InternalUtils.NAME_PREFIX.indexOf(ch) < 0) break;
>             builder.deleteCharAt(builder.length-1);
>         }
> Cheers,
> Adriaan

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2236) Strip of _ suffix in class transformation

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630633#action_12630633 ] 

Howard M. Lewis Ship commented on TAPESTRY-2236:
------------------------------------------------

I would have worked on this one earilier if you had set the affects version field. 

> Strip of _ suffix in class transformation
> -----------------------------------------
>
>                 Key: TAPESTRY-2236
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2236
>             Project: Tapestry
>          Issue Type: Improvement
>    Affects Versions: 5.0
>         Environment: Tapestry 5.0.11-SNAPSHOT
>            Reporter: Adriaan Joubert
>            Assignee: Howard M. Lewis Ship
>
> Hi,
> our convention is to use an _ suffix for fields, rather than a prefix. Tapestry cannot naturally transform these field names where needed. Could you please change 
> org.apache.tapestry.ioc.internal.util.InternalUtils.stripMemberPrefix(String memberName)
> to strip an _ suffix as well. The following addition should do the job
>        while (builder.length>0)
>         {
>             char ch = builder.charAt(builder.length-1);
>             if (InternalUtils.NAME_PREFIX.indexOf(ch) < 0) break;
>             builder.deleteCharAt(builder.length-1);
>         }
> Cheers,
> Adriaan

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-2236) Strip of _ suffix in class transformation

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAPESTRY-2236:
-------------------------------------------

    Affects Version/s: 5.0

> Strip of _ suffix in class transformation
> -----------------------------------------
>
>                 Key: TAPESTRY-2236
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2236
>             Project: Tapestry
>          Issue Type: Improvement
>    Affects Versions: 5.0
>         Environment: Tapestry 5.0.11-SNAPSHOT
>            Reporter: Adriaan Joubert
>
> Hi,
> our convention is to use an _ suffix for fields, rather than a prefix. Tapestry cannot naturally transform these field names where needed. Could you please change 
> org.apache.tapestry.ioc.internal.util.InternalUtils.stripMemberPrefix(String memberName)
> to strip an _ suffix as well. The following addition should do the job
>        while (builder.length>0)
>         {
>             char ch = builder.charAt(builder.length-1);
>             if (InternalUtils.NAME_PREFIX.indexOf(ch) < 0) break;
>             builder.deleteCharAt(builder.length-1);
>         }
> Cheers,
> Adriaan

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Assigned: (TAPESTRY-2236) Strip of _ suffix in class transformation

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAPESTRY-2236:
----------------------------------------------

    Assignee: Howard M. Lewis Ship

> Strip of _ suffix in class transformation
> -----------------------------------------
>
>                 Key: TAPESTRY-2236
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2236
>             Project: Tapestry
>          Issue Type: Improvement
>    Affects Versions: 5.0
>         Environment: Tapestry 5.0.11-SNAPSHOT
>            Reporter: Adriaan Joubert
>            Assignee: Howard M. Lewis Ship
>
> Hi,
> our convention is to use an _ suffix for fields, rather than a prefix. Tapestry cannot naturally transform these field names where needed. Could you please change 
> org.apache.tapestry.ioc.internal.util.InternalUtils.stripMemberPrefix(String memberName)
> to strip an _ suffix as well. The following addition should do the job
>        while (builder.length>0)
>         {
>             char ch = builder.charAt(builder.length-1);
>             if (InternalUtils.NAME_PREFIX.indexOf(ch) < 0) break;
>             builder.deleteCharAt(builder.length-1);
>         }
> Cheers,
> Adriaan

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org