[jira] [Commented] (SLING-7062) Commons metrics inventory closes zip

["Chetan Mehrotra (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134710#comment-16134710 ] 

Chetan Mehrotra commented on SLING-7062:
----------------------------------------

Thanks [~mreutegg] for the patch. Did a slightly different change as we still need to flush the writer created within JSONReporter.

Did a fix with 1805597 along with some testcase to ensure that writer does not get closed

[~cziegeler] Should we modify the inventory implementation such that it ensures that underlying stream does not get closed by any of the printers

> Commons metrics inventory closes zip
> ------------------------------------
>
>                 Key: SLING-7062
>                 URL: https://issues.apache.org/jira/browse/SLING-7062
>             Project: Sling
>          Issue Type: Bug
>          Components: Commons
>    Affects Versions: Commons Metrics 1.0.0
>            Reporter: Marcel Reutegger
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: commons metrics 1.2.4
>
>         Attachments: SLING-7062.patch
>
>
> The inventory printer implementation of {{MetricWebConsolePlugin}} closes the passed {{PrintWriter}} though {{ConsoleReporter.close()}}. This aborts the configuration status zip generation process and subsequent inventory printer output is missing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)