You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/10 19:15:00 UTC
[jira] [Commented] (JENA-1484) ElementData transformation fails due
to bug in ApplyElementTransformVisitor
[ https://issues.apache.org/jira/browse/JENA-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359611#comment-16359611 ]
ASF GitHub Bot commented on JENA-1484:
--------------------------------------
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/358
JENA-1484: Correcting behavior in ApplyElementTransformVisitor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena JENA-1484
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/358.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #358
----
commit c706ea4a7792221aa83bc4d5a9600ca4be89c4d2
Author: ajs6f <aj...@...>
Date: 2018-02-10T19:14:12Z
JENA-1484: Correcting behavior in ApplyElementTransformVisitor
----
> ElementData transformation fails due to bug in ApplyElementTransformVisitor
> ---------------------------------------------------------------------------
>
> Key: JENA-1484
> URL: https://issues.apache.org/jira/browse/JENA-1484
> Project: Apache Jena
> Issue Type: Bug
> Components: ARQ
> Affects Versions: Jena 3.6.0
> Reporter: Claus Stadler
> Priority: Major
>
> Applying a NodeTransform to an ElementData has no effect due to a mistake in
> org.apache.jena.sparql.syntax.syntaxtransform.ApplyElementTransformVisitor
> {code:java}
> // BUGGED implementation as of Jena 3.6.0:
> @Override
> public void visit(ElementData el) {
> transform.transform(el) ;
> push(el) ;
> }
> // should be:
> @Override
> public void visit(ElementData el) {
> Element el2 = transform.transform(el) ;
> push(el2) ;
> }
> // analogous to:
> @Override
> public void visit(ElementOptional el) {
> Element elSub = pop() ;
> Element el2 = transform.transform(el, elSub) ;
> push(el2) ;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)