You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/07/14 16:26:48 UTC

Review Request 60870: AMBARI-21478. Wrong string quoting in get_stack_version

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60870/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sebastian Toader.


Bugs: AMBARI-21478
    https://issues.apache.org/jira/browse/AMBARI-21478


Repository: ambari


Description
-------

Use same quote symbol


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py 463d61f53dcc5bdceef25a89521afda63d61e0ef 


Diff: https://reviews.apache.org/r/60870/diff/1/


Testing
-------

Ambari Agent python tests:

```
Ran 470 tests in 27.659s

OK
```

Ambari Server python tests:

```
Total run:1145
Total errors:0
Total failures:0
OK
```


Thanks,

Attila Doroszlai


Re: Review Request 60870: AMBARI-21478. Wrong string quoting in get_stack_version

Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60870/#review180540
-----------------------------------------------------------


Ship it!




Ship It!

- Sebastian Toader


On July 14, 2017, 6:26 p.m., Attila Doroszlai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60870/
> -----------------------------------------------------------
> 
> (Updated July 14, 2017, 6:26 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21478
>     https://issues.apache.org/jira/browse/AMBARI-21478
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Use same quote symbol
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py 463d61f53dcc5bdceef25a89521afda63d61e0ef 
> 
> 
> Diff: https://reviews.apache.org/r/60870/diff/1/
> 
> 
> Testing
> -------
> 
> Ambari Agent python tests:
> 
> ```
> Ran 470 tests in 27.659s
> 
> OK
> ```
> 
> Ambari Server python tests:
> 
> ```
> Total run:1145
> Total errors:0
> Total failures:0
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>