[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1310: SOLR-13350: Multithreaded search using collector managers

[GitBox <gi...@apache.org>]

mkhludnev commented on a change in pull request #1310:
URL: https://github.com/apache/lucene-solr/pull/1310#discussion_r480114845



##########
File path: solr/core/src/java/org/apache/solr/core/NodeConfig.java
##########
@@ -309,6 +317,7 @@ public boolean isFromZookeeper() {
     private final String nodeName;
 
     public static final int DEFAULT_CORE_LOAD_THREADS = 3;
+    public static final int DEFAULT_COLLECTORS_POOL_SIZE = 32768;

Review comment:
       Is it number of threads? Ins't it too many? 

##########
File path: solr/core/src/java/org/apache/solr/search/TopLevelJoinQuery.java
##########
@@ -62,7 +62,7 @@ public Weight createWeight(IndexSearcher searcher, ScoreMode scoreMode, float bo
 
     final SolrIndexSearcher solrSearcher = (SolrIndexSearcher) searcher;
     final JoinQueryWeight weight = new JoinQueryWeight(solrSearcher, ScoreMode.COMPLETE_NO_SCORES, 1.0f);
-    final SolrIndexSearcher fromSearcher = weight.fromSearcher;
+    final SolrIndexSearcher fromSearcher = weight.toSearcher; // fromIndex isn't specified, so this has to be toSearcher

Review comment:
       but what if `fromIndex` is specified?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org