You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/12/07 14:49:38 UTC

[GitHub] rymanluk commented on a change in pull request #248: nimble host stack should not consider connection handle 0 as invalid.

rymanluk commented on a change in pull request #248: nimble host stack should not consider connection handle 0 as invalid.
URL: https://github.com/apache/mynewt-nimble/pull/248#discussion_r239828626
 
 

 ##########
 File path: nimble/host/mesh/src/proxy.c
 ##########
 @@ -877,7 +878,7 @@ bool bt_mesh_proxy_relay(struct os_mbuf *buf, u16_t dst)
 		struct bt_mesh_proxy_client *client = &clients[i];
 		struct os_mbuf *msg;
 
-		if (!client->conn_handle) {
+		if (clients[i].conn_handle == BLE_HS_CONN_HANDLE_NONE) {
 
 Review comment:
   since there is `*client`, let us use it:
    if (client->conn_handle == BLE_HS_CONN_HANDLE_NONE) {}

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services