You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2015/07/27 05:18:09 UTC
Review Request 36834: Update the util to generate the command for
audit log
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36834/
-----------------------------------------------------------
Review request for sentry, Dapeng Sun and shen guoquan.
Repository: sentry
Description
-------
Update the util to generate the command for audit log
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java 741cfdc
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java 072a0e8
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java 0a2b0b2
Diff: https://reviews.apache.org/r/36834/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 36834: SENTRY-815: Update the util to generate the
command for audit log
Posted by Dapeng Sun <da...@intel.com>.
> On 八月 10, 2015, 9:10 a.m., Dapeng Sun wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java, line 170
> > <https://reviews.apache.org/r/36834/diff/1/?file=1022155#file1022155line170>
> >
> > Same above: could we use short class name here? I found many places use long class names.
>
> Colin Ma wrote:
> Unfortunately, I have to use long class names here, because TAlterSentryRoleRevokePrivilegeRequest has the same class name but different package name for hive model and generic model.
> The util class need include both class, one of them has to be with long class name.
Okay, I see. @Guoquan, do you think we can change the classname of Generic model?
- Dapeng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36834/#review94689
-----------------------------------------------------------
On 八月 13, 2015, 1:07 p.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36834/
> -----------------------------------------------------------
>
> (Updated 八月 13, 2015, 1:07 p.m.)
>
>
> Review request for sentry, Dapeng Sun and shen guoquan.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update the util to generate the command for audit log
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java 741cfdc
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java 072a0e8
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java 0a2b0b2
>
> Diff: https://reviews.apache.org/r/36834/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 36834: Update the util to generate the command for
audit log
Posted by Colin Ma <ju...@intel.com>.
> On Aug. 10, 2015, 1:10 a.m., Dapeng Sun wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java, line 170
> > <https://reviews.apache.org/r/36834/diff/1/?file=1022155#file1022155line170>
> >
> > Same above: could we use short class name here? I found many places use long class names.
Unfortunately, I have to use long class names here, because TAlterSentryRoleRevokePrivilegeRequest has the same class name but different package name for hive model and generic model.
The util class need include both class, one of them has to be with long class name.
- Colin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36834/#review94689
-----------------------------------------------------------
On July 27, 2015, 3:18 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36834/
> -----------------------------------------------------------
>
> (Updated July 27, 2015, 3:18 a.m.)
>
>
> Review request for sentry, Dapeng Sun and shen guoquan.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update the util to generate the command for audit log
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java 741cfdc
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java 072a0e8
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java 0a2b0b2
>
> Diff: https://reviews.apache.org/r/36834/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 36834: Update the util to generate the command for
audit log
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36834/#review94689
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java (line 149)
<https://reviews.apache.org/r/36834/#comment149299>
Could we use short class name here?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java (line 155)
<https://reviews.apache.org/r/36834/#comment149300>
Same above: could we use short class name here? I found many places use long class names.
- Dapeng Sun
On 七月 27, 2015, 11:18 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36834/
> -----------------------------------------------------------
>
> (Updated 七月 27, 2015, 11:18 a.m.)
>
>
> Review request for sentry, Dapeng Sun and shen guoquan.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update the util to generate the command for audit log
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java 741cfdc
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java 072a0e8
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java 0a2b0b2
>
> Diff: https://reviews.apache.org/r/36834/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 36834: Update the util to generate the command for
audit log
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36834/#review93226
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java (line 85)
<https://reviews.apache.org/r/36834/#comment147549>
It seems this added code wasn't used in this jira. I can't find any other source related it
- shen guoquan
On 七月 27, 2015, 3:18 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36834/
> -----------------------------------------------------------
>
> (Updated 七月 27, 2015, 3:18 a.m.)
>
>
> Review request for sentry, Dapeng Sun and shen guoquan.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update the util to generate the command for audit log
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java 741cfdc
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java 072a0e8
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java 0a2b0b2
>
> Diff: https://reviews.apache.org/r/36834/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>