You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/15 02:57:33 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request #17754: doc: update contribuing docs
zhaoyongjie opened a new pull request #17754:
URL: https://github.com/apache/superset/pull/17754
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
1. remove unused superset-ui section
2. fix dead link
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] riahk commented on a change in pull request #17754: docs: update contribuing docs
Posted by GitBox <gi...@apache.org>.
riahk commented on a change in pull request #17754:
URL: https://github.com/apache/superset/pull/17754#discussion_r770055716
##########
File path: CONTRIBUTING.md
##########
@@ -728,7 +715,7 @@ def sqrt(x: Union[float, int]) -> Union[float, int]:
return math.sqrt(x)
```
-### TypeScript
+### TypeScript Typing
Review comment:
This feels a bit redundant imo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] riahk merged pull request #17754: docs: update contribuing docs
Posted by GitBox <gi...@apache.org>.
riahk merged pull request #17754:
URL: https://github.com/apache/superset/pull/17754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17754: docs: update contribuing docs
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17754:
URL: https://github.com/apache/superset/pull/17754#discussion_r771084085
##########
File path: CONTRIBUTING.md
##########
@@ -728,7 +715,7 @@ def sqrt(x: Union[float, int]) -> Union[float, int]:
return math.sqrt(x)
```
-### TypeScript
+### TypeScript Typing
Review comment:
The `Typescript in Linting` and `Typescript in Typescript` are in conflict, so the Table of Contents hasn't `typescript` in `Linting` section
<img width="618" alt="image" src="https://user-images.githubusercontent.com/2016594/146484690-c0375b13-2caa-41d0-9708-342ef8fbd06c.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17754: docs: update contribuing docs
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17754:
URL: https://github.com/apache/superset/pull/17754#discussion_r771084085
##########
File path: CONTRIBUTING.md
##########
@@ -728,7 +715,7 @@ def sqrt(x: Union[float, int]) -> Union[float, int]:
return math.sqrt(x)
```
-### TypeScript
+### TypeScript Typing
Review comment:
The `Typescript in Linting` and `Typescript in Typescript` are in conflict, so the Table of Contents isn't `typescript` in `Linting` section
<img width="618" alt="image" src="https://user-images.githubusercontent.com/2016594/146484690-c0375b13-2caa-41d0-9708-342ef8fbd06c.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #17754: docs: update contribuing docs
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #17754:
URL: https://github.com/apache/superset/pull/17754#issuecomment-994409305
@riahk can you take a look at these changes? FYI @zhaoyongjie , Moriah is moving these sections into the docs section, so in the future the majority of this will be featured in the official documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org