You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/29 15:55:40 UTC
[GitHub] codecov-io edited a comment on issue #5769: [refactor] moving some
datasource-related code to the frontend
codecov-io edited a comment on issue #5769: [refactor] moving some datasource-related code to the frontend
URL: https://github.com/apache/incubator-superset/pull/5769#issuecomment-417002399
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5769?src=pr&el=h1) Report
> Merging [#5769](https://codecov.io/gh/apache/incubator-superset/pull/5769?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/135539c109a90a5f13af8da0cc9842d3753b3bfe?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `22.22%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5769?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5769 +/- ##
==========================================
+ Coverage 63.82% 63.83% +0.01%
==========================================
Files 364 364
Lines 23059 23044 -15
Branches 2568 2557 -11
==========================================
- Hits 14717 14711 -6
+ Misses 8327 8318 -9
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5769?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5769/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.81% <ø> (-0.69%)` | :arrow_down: |
| [superset/assets/src/visualizations/sunburst.js](https://codecov.io/gh/apache/incubator-superset/pull/5769/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9zdW5idXJzdC5qcw==) | `0% <ø> (ø)` | :arrow_up: |
| [...uperset/assets/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5769/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXRhc291cmNlL0RhdGFzb3VyY2VFZGl0b3IuanN4) | `72.52% <0%> (-0.41%)` | :arrow_down: |
| [...plore/components/controls/FixedOrMetricControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5769/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvRml4ZWRPck1ldHJpY0NvbnRyb2wuanN4) | `87.5% <100%> (-0.5%)` | :arrow_down: |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5769/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `50.4% <16.66%> (+4.13%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5769?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5769?src=pr&el=footer). Last update [135539c...4166162](https://codecov.io/gh/apache/incubator-superset/pull/5769?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org