You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2017/03/10 18:39:10 UTC
Review Request 57517: [Upgrade] Unable to enable Credential store
support on upgraded clusters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57517/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.
Bugs: AMBARI-20399
https://issues.apache.org/jira/browse/AMBARI-20399
Repository: ambari
Description
-------
ServiceInfo was not being refreshed on stack upgrade
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java b1bffef
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 70efeb5
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d12a8a3
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java 2bfd176
Diff: https://reviews.apache.org/r/57517/diff/1/
Testing
-------
Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path)
Verified that credential_store_supported = true for Oozie, Hive, Logsearch
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 57517: [Upgrade] Unable to enable Credential store
support on upgraded clusters
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57517/#review168672
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On March 10, 2017, 2:59 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57517/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 2:59 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20399
> https://issues.apache.org/jira/browse/AMBARI-20399
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ServiceInfo was not being refreshed on stack upgrade
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java b1bffef
> ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 70efeb5
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d12a8a3
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java 2bfd176
>
>
> Diff: https://reviews.apache.org/r/57517/diff/2/
>
>
> Testing
> -------
>
> Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path)
> Verified that credential_store_supported = true for Oozie, Hive, Logsearch
>
> [INFO] Starting audit...
> Audit done.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:08 min
> [INFO] Finished at: 2017-03-10T11:56:37-08:00
> [INFO] Final Memory: 66M/1105M
> [INFO] ------------------------------------------------------------------------
> mradhakrishnan$ mvn clean test -Drat.skip=true
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 57517: [Upgrade] Unable to enable Credential store
support on upgraded clusters
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57517/
-----------------------------------------------------------
(Updated March 10, 2017, 7:59 p.m.)
Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.
Bugs: AMBARI-20399
https://issues.apache.org/jira/browse/AMBARI-20399
Repository: ambari
Description
-------
ServiceInfo was not being refreshed on stack upgrade
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java b1bffef
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 70efeb5
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d12a8a3
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java 2bfd176
Diff: https://reviews.apache.org/r/57517/diff/2/
Testing (updated)
-------
Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path)
Verified that credential_store_supported = true for Oozie, Hive, Logsearch
[INFO] Starting audit...
Audit done.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:08 min
[INFO] Finished at: 2017-03-10T11:56:37-08:00
[INFO] Final Memory: 66M/1105M
[INFO] ------------------------------------------------------------------------
mradhakrishnan$ mvn clean test -Drat.skip=true
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 57517: [Upgrade] Unable to enable Credential store
support on upgraded clusters
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57517/
-----------------------------------------------------------
(Updated March 10, 2017, 7:58 p.m.)
Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.
Changes
-------
Incorporated review comments
Bugs: AMBARI-20399
https://issues.apache.org/jira/browse/AMBARI-20399
Repository: ambari
Description
-------
ServiceInfo was not being refreshed on stack upgrade
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java b1bffef
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 70efeb5
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d12a8a3
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java 2bfd176
Diff: https://reviews.apache.org/r/57517/diff/2/
Changes: https://reviews.apache.org/r/57517/diff/1-2/
Testing
-------
Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path)
Verified that credential_store_supported = true for Oozie, Hive, Logsearch
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 57517: [Upgrade] Unable to enable Credential store
support on upgraded clusters
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
> On March 10, 2017, 6:47 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
> > Lines 198 (patched)
> > <https://reviews.apache.org/r/57517/diff/1/?file=1661517#file1661517line198>
> >
> > This log statement isn't very helpful (since the logger itself outputs the class/method automatically).
> >
> > Also, you don't need `this` in `this.getName()`
Sorry , i forgot to remove the log statements after my testing. Will clean it up.
> On March 10, 2017, 6:47 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
> > Lines 200-202 (patched)
> > <https://reviews.apache.org/r/57517/diff/1/?file=1661517#file1661517line200>
> >
> > Shouldn't all metadata be refreshed in this, not just credential store?
Here are the metadata for ServiceInfo
"cluster_name": "",-->Does it require a refresh?
"credential_store_enabled": "false", --> I believe we dont want this information to come from the stack i.e expectation is that after an upgrade this will still be in disabled state. Please correct me if I am wrong.
"credential_store_supported": "true", --> refreshed
"maintenance_state": "OFF", -->Does it require a refresh?
"service_name": "OOZIE",-->Does it require a refresh?
"state": "STARTED"-->Does it require a refresh?
- Madhuvanthi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57517/#review168646
-----------------------------------------------------------
On March 10, 2017, 6:39 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57517/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 6:39 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20399
> https://issues.apache.org/jira/browse/AMBARI-20399
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ServiceInfo was not being refreshed on stack upgrade
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java b1bffef
> ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 70efeb5
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d12a8a3
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java 2bfd176
>
>
> Diff: https://reviews.apache.org/r/57517/diff/1/
>
>
> Testing
> -------
>
> Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path)
> Verified that credential_store_supported = true for Oozie, Hive, Logsearch
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 57517: [Upgrade] Unable to enable Credential store
support on upgraded clusters
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On March 10, 2017, 1:47 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
> > Lines 200-202 (patched)
> > <https://reviews.apache.org/r/57517/diff/1/?file=1661517#file1661517line200>
> >
> > Shouldn't all metadata be refreshed in this, not just credential store?
>
> Madhuvanthi Radhakrishnan wrote:
> Here are the metadata for ServiceInfo
> "cluster_name": "",-->Does it require a refresh?
> "credential_store_enabled": "false", --> I believe we dont want this information to come from the stack i.e expectation is that after an upgrade this will still be in disabled state. Please correct me if I am wrong.
> "credential_store_supported": "true", --> refreshed
> "maintenance_state": "OFF", -->Does it require a refresh?
> "service_name": "OOZIE",-->Does it require a refresh?
> "state": "STARTED"-->Does it require a refresh?
OK, so a lot of that doesn't come from the ServiceInfo. These do:
isClientOnlyService = sInfo.isClientOnlyService();
isCredentialStoreSupported = sInfo.isCredentialStoreSupported();
isCredentialStoreRequired = sInfo.isCredentialStoreRequired();
If any of them change between stacks, then I think we should update the internal state.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57517/#review168646
-----------------------------------------------------------
On March 10, 2017, 1:39 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57517/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 1:39 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20399
> https://issues.apache.org/jira/browse/AMBARI-20399
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ServiceInfo was not being refreshed on stack upgrade
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java b1bffef
> ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 70efeb5
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d12a8a3
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java 2bfd176
>
>
> Diff: https://reviews.apache.org/r/57517/diff/1/
>
>
> Testing
> -------
>
> Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path)
> Verified that credential_store_supported = true for Oozie, Hive, Logsearch
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 57517: [Upgrade] Unable to enable Credential store
support on upgraded clusters
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57517/#review168646
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
Line 74 (original), 76 (patched)
<https://reviews.apache.org/r/57517/#comment240886>
Formatting here looks off.
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
Lines 198 (patched)
<https://reviews.apache.org/r/57517/#comment240884>
This log statement isn't very helpful (since the logger itself outputs the class/method automatically).
Also, you don't need `this` in `this.getName()`
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
Lines 200-202 (patched)
<https://reviews.apache.org/r/57517/#comment240885>
Shouldn't all metadata be refreshed in this, not just credential store?
- Jonathan Hurley
On March 10, 2017, 1:39 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57517/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 1:39 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20399
> https://issues.apache.org/jira/browse/AMBARI-20399
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ServiceInfo was not being refreshed on stack upgrade
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java b1bffef
> ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 70efeb5
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d12a8a3
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java 2bfd176
>
>
> Diff: https://reviews.apache.org/r/57517/diff/1/
>
>
> Testing
> -------
>
> Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path)
> Verified that credential_store_supported = true for Oozie, Hive, Logsearch
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>