You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/18 09:41:01 UTC
[GitHub] [flink] SteNicholas opened a new pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
SteNicholas opened a new pull request #13676:
URL: https://github.com/apache/flink/pull/13676
## What is the purpose of the change
*With the deprecation of `StreamExecutionEnvironment.setStreamTimeCharacteristic()`, we need a way of explicitly configuring the time behaviour of CEP operations. Currently, all CEP operations use the characteristic to configure themselves. `PatternStream` could add `inProcessingTIme` and `inEventTime` that specify time behaviour to processing time or event time.*
## Brief change log
- *`PatternStream` adds `inProcessingTIme` and `inEventTime` method instead of `setStreamTimeCharacteristic()` that specify time behaviour to processing time or event time.*
## Verifying this change
- *Modify `CEPITCase` test cases which use `StreamExecutionEnvironment.setStreamTimeCharacteristic()` through `CEP.pattern(input, pattern, isProcessingTime`) to verify the `inProcessingTIme` of `PatternStream` whether could be instead of `setStreamTimeCharacteristic()`.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-716563935
Good work, I merged this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-712780047
@aljoscha ,thanks for your detailed explanation. Please help to review this pull requests again if you are available. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #13676:
URL: https://github.com/apache/flink/pull/13676#discussion_r508277562
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/CEP.java
##########
@@ -52,7 +52,48 @@
DataStream<T> input,
Pattern<T, ?> pattern,
EventComparator<T> comparator) {
- final PatternStream<T> stream = new PatternStream<>(input, pattern);
- return stream.withComparator(comparator);
+ return new PatternStream<>(input, pattern).withComparator(comparator);
+ }
+
+ /**
+ * Creates a {@link PatternStream} from an input data stream and a pattern.
+ *
+ * @param input DataStream containing the input events
+ * @param pattern Pattern specification which shall be detected
+ * @param isProcessingTime Time behaviour to specify processing time or event time
+ * @param <T> Type of the input events
+ * @return Resulting pattern stream
+ */
+ public static <T> PatternStream<T> pattern(
+ DataStream<T> input,
+ Pattern<T, ?> pattern,
+ boolean isProcessingTime) {
Review comment:
I still think having this as a parameter would not be very user friendly, seeing a call like `pattern(in, foo, false)` makes it very hard to know what the `false` means. If you see, however, `pattern(in, foo).inProcessingTime()` it's immediately obvious what's going on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
}, {
"hash" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931",
"triggerID" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"triggerType" : "PUSH"
}, {
"hash" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7935",
"triggerID" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dca4699aaba410b65186c7ae688d6e47f44ffaaf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931)
* 97bc6647345b7c4b5b2a85c81a9f0f9052d37d88 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7935)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas removed a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-712553220
> I had a preliminary review. Overall this looks good but I had some comments on the API.
@aljoscha thanks for your preliminary review. I have already replied the comments you mentioned. Please take a look if you are available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55b7593928c1e8b4103cc12ae87f9580ef33f06c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e96b1f432be1a43daee779a11fe2cf680580068 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818)
* 04b5e6bc606ef9f43205e3f521ab634ee7de5172 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711142815
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 55b7593928c1e8b4103cc12ae87f9580ef33f06c (Sun Oct 18 09:43:49 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e96b1f432be1a43daee779a11fe2cf680580068 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818)
* 04b5e6bc606ef9f43205e3f521ab634ee7de5172 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #13676:
URL: https://github.com/apache/flink/pull/13676#discussion_r507652668
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/CEP.java
##########
@@ -52,7 +52,48 @@
DataStream<T> input,
Pattern<T, ?> pattern,
EventComparator<T> comparator) {
- final PatternStream<T> stream = new PatternStream<>(input, pattern);
- return stream.withComparator(comparator);
+ return new PatternStream<>(input, pattern).withComparator(comparator);
+ }
+
+ /**
+ * Creates a {@link PatternStream} from an input data stream and a pattern.
+ *
+ * @param input DataStream containing the input events
+ * @param pattern Pattern specification which shall be detected
+ * @param isProcessingTime Time behaviour to specify processing time or event time
+ * @param <T> Type of the input events
+ * @return Resulting pattern stream
+ */
+ public static <T> PatternStream<T> pattern(
+ DataStream<T> input,
+ Pattern<T, ?> pattern,
+ boolean isProcessingTime) {
Review comment:
I think we don't need to expose an additional parameter because users can use `inProcessingTime()` and `inEventTime()` right?
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/CEP.java
##########
@@ -52,7 +52,48 @@
DataStream<T> input,
Pattern<T, ?> pattern,
EventComparator<T> comparator) {
- final PatternStream<T> stream = new PatternStream<>(input, pattern);
- return stream.withComparator(comparator);
+ return new PatternStream<>(input, pattern).withComparator(comparator);
+ }
+
+ /**
+ * Creates a {@link PatternStream} from an input data stream and a pattern.
+ *
+ * @param input DataStream containing the input events
+ * @param pattern Pattern specification which shall be detected
+ * @param isProcessingTime Time behaviour to specify processing time or event time
+ * @param <T> Type of the input events
+ * @return Resulting pattern stream
+ */
+ public static <T> PatternStream<T> pattern(
+ DataStream<T> input,
+ Pattern<T, ?> pattern,
+ boolean isProcessingTime) {
Review comment:
It's better to just have one way of doing things. Keeps the API simpler. What do you think?
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStreamBuilder.java
##########
@@ -60,14 +59,28 @@
*/
private final OutputTag<IN> lateDataOutputTag;
+ private boolean isProcessingTime;
Review comment:
I think it would be better to introduce an enum for this. Sth like `TimeCharacteristic` that has `PROCESSING_TIME` and `EVENT_TIME`. I find it's often hard to see what `true` or `false` mean when you just read a method call.
This should be internal, though, and the only API for users should be `inEventTime()` and `inProcessingTime()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55b7593928c1e8b4103cc12ae87f9580ef33f06c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #13676:
URL: https://github.com/apache/flink/pull/13676#discussion_r508276355
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStreamBuilder.java
##########
@@ -60,14 +59,28 @@
*/
private final OutputTag<IN> lateDataOutputTag;
+ private boolean isProcessingTime;
Review comment:
Users wouldn't see it because it's only internal. And having an enum will be more maintainable because, again, just seeing `true` or `false` in code makes it very hard to know what it means.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #13676:
URL: https://github.com/apache/flink/pull/13676#discussion_r507658831
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/CEP.java
##########
@@ -52,7 +52,48 @@
DataStream<T> input,
Pattern<T, ?> pattern,
EventComparator<T> comparator) {
- final PatternStream<T> stream = new PatternStream<>(input, pattern);
- return stream.withComparator(comparator);
+ return new PatternStream<>(input, pattern).withComparator(comparator);
+ }
+
+ /**
+ * Creates a {@link PatternStream} from an input data stream and a pattern.
+ *
+ * @param input DataStream containing the input events
+ * @param pattern Pattern specification which shall be detected
+ * @param isProcessingTime Time behaviour to specify processing time or event time
+ * @param <T> Type of the input events
+ * @return Resulting pattern stream
+ */
+ public static <T> PatternStream<T> pattern(
+ DataStream<T> input,
+ Pattern<T, ?> pattern,
+ boolean isProcessingTime) {
Review comment:
@aljoscha I thought that this could provide this interface to directly create PatternStream in processing time with parameter, and this is user-friendly interface. Your point that keeping the API simpler is right, but for users, IMO, it's better to specify the time behaviour by parameter, not extrally calling `inProcessingTime()` and `inEventTime()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-716506412
> Thanks for your work! I pushed some changes to your branch, I hope that's ok. I split the unrelated changes that remove imports. I also fixed the `PatternStreamBuilder`, the problem with the code before was that the time characteristic would be dropped when calling the builder methods that don't call the right constructor. And I changed `DataStreamMatch` to use an explicit type instead of a boolean, because it's hard to parse what they mean when looking at the code in passing.
>
> Please let me know if you're ok with the changed, then I'd merge once CI is green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas removed a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-716506412
> Thanks for your work! I pushed some changes to your branch, I hope that's ok. I split the unrelated changes that remove imports. I also fixed the `PatternStreamBuilder`, the problem with the code before was that the time characteristic would be dropped when calling the builder methods that don't call the right constructor. And I changed `DataStreamMatch` to use an explicit type instead of a boolean, because it's hard to parse what they mean when looking at the code in passing.
>
> Please let me know if you're ok with the changed, then I'd merge once CI is green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #13676:
URL: https://github.com/apache/flink/pull/13676#discussion_r508293285
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStreamBuilder.java
##########
@@ -60,14 +59,28 @@
*/
private final OutputTag<IN> lateDataOutputTag;
+ private boolean isProcessingTime;
Review comment:
@aljoscha Yeah. I would like to add enum for processing time and event time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-716508485
> Ah sorry, your other changes took very good. The API is very clean now. 👌
@aljoscha , thanks for your detailed review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-712732952
@aljoscha ,thanks for your detailed explanation. Please help to review this pull requests again if you are available. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
}, {
"hash" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931",
"triggerID" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"triggerType" : "PUSH"
}, {
"hash" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7935",
"triggerID" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"triggerType" : "PUSH"
}, {
"hash" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7940",
"triggerID" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"triggerType" : "PUSH"
}, {
"hash" : "7c8f33c27cb6cdfa1682585c9611251d8dcad5a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8143",
"triggerID" : "7c8f33c27cb6cdfa1682585c9611251d8dcad5a7",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "716506904",
"triggerType" : "MANUAL"
}, {
"hash" : "f519b87c25d5a528e7db19e3fffbc2e097bd4772",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8294",
"triggerID" : "716506904",
"triggerType" : "MANUAL"
}, {
"hash" : "f519b87c25d5a528e7db19e3fffbc2e097bd4772",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8294",
"triggerID" : "f519b87c25d5a528e7db19e3fffbc2e097bd4772",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* f519b87c25d5a528e7db19e3fffbc2e097bd4772 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8294)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-712780047
@aljoscha ,thanks for your detailed explanation. Please review this pull requests again if you are available. Thanks very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55b7593928c1e8b4103cc12ae87f9580ef33f06c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804)
* 0e96b1f432be1a43daee779a11fe2cf680580068 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #13676:
URL: https://github.com/apache/flink/pull/13676#discussion_r507660319
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStreamBuilder.java
##########
@@ -60,14 +59,28 @@
*/
private final OutputTag<IN> lateDataOutputTag;
+ private boolean isProcessingTime;
Review comment:
@aljoscha I previously consider the enum like `TimeCharacteristic`, but this enum is only used in this which makes little sense and confused for users in 1.11 version.
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStreamBuilder.java
##########
@@ -60,14 +59,28 @@
*/
private final OutputTag<IN> lateDataOutputTag;
+ private boolean isProcessingTime;
Review comment:
@aljoscha I previously considered the enum like `TimeCharacteristic`, but this enum is only used in this which makes little sense and confused for users in 1.11 version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #13676:
URL: https://github.com/apache/flink/pull/13676#discussion_r508292895
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/CEP.java
##########
@@ -52,7 +52,48 @@
DataStream<T> input,
Pattern<T, ?> pattern,
EventComparator<T> comparator) {
- final PatternStream<T> stream = new PatternStream<>(input, pattern);
- return stream.withComparator(comparator);
+ return new PatternStream<>(input, pattern).withComparator(comparator);
+ }
+
+ /**
+ * Creates a {@link PatternStream} from an input data stream and a pattern.
+ *
+ * @param input DataStream containing the input events
+ * @param pattern Pattern specification which shall be detected
+ * @param isProcessingTime Time behaviour to specify processing time or event time
+ * @param <T> Type of the input events
+ * @return Resulting pattern stream
+ */
+ public static <T> PatternStream<T> pattern(
+ DataStream<T> input,
+ Pattern<T, ?> pattern,
+ boolean isProcessingTime) {
Review comment:
@aljoscha I would like to follow up the points you mentioned later to update the methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
}, {
"hash" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931",
"triggerID" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"triggerType" : "PUSH"
}, {
"hash" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dca4699aaba410b65186c7ae688d6e47f44ffaaf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931)
* 97bc6647345b7c4b5b2a85c81a9f0f9052d37d88 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04b5e6bc606ef9f43205e3f521ab634ee7de5172 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-716507003
> @SteNicholas Thanks for your work! I pushed some changes to your branch, I hope that's ok. I split the unrelated changes that remove imports. I also fixed the `PatternStreamBuilder`, the problem with the code before was that the time characteristic would be dropped when calling the builder methods that don't call the right constructor. And I changed `DataStreamMatch` to use an explicit type instead of a boolean, because it's hard to parse what they mean when looking at the code in passing.
>
> Please let me know if you're ok with the changed, then I'd merge once CI is green.
@aljoscha Your changes are ok for me. Please go ahead to do some changes. And no any comments with my changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
}, {
"hash" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04b5e6bc606ef9f43205e3f521ab634ee7de5172 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822)
* dca4699aaba410b65186c7ae688d6e47f44ffaaf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-714431433
@aljoscha ,thanks for your detailed explanation. Please review this pull requests again if you are available. Thanks very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
}, {
"hash" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931",
"triggerID" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"triggerType" : "PUSH"
}, {
"hash" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7935",
"triggerID" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"triggerType" : "PUSH"
}, {
"hash" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dca4699aaba410b65186c7ae688d6e47f44ffaaf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931)
* 97bc6647345b7c4b5b2a85c81a9f0f9052d37d88 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7935)
* 80e2c4e0a1fff42e9c2d2798ed7884a148870ee5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas closed pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas closed pull request #13676:
URL: https://github.com/apache/flink/pull/13676
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-712553220
> I had a preliminary review. Overall this looks good but I had some comments on the API.
@aljoscha thanks for your preliminary review. I have already replied the comments you mentioned. Please take a look if you are available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55b7593928c1e8b4103cc12ae87f9580ef33f06c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
}, {
"hash" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931",
"triggerID" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"triggerType" : "PUSH"
}, {
"hash" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7935",
"triggerID" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"triggerType" : "PUSH"
}, {
"hash" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7940",
"triggerID" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"triggerType" : "PUSH"
}, {
"hash" : "7c8f33c27cb6cdfa1682585c9611251d8dcad5a7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7c8f33c27cb6cdfa1682585c9611251d8dcad5a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 80e2c4e0a1fff42e9c2d2798ed7884a148870ee5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7940)
* 7c8f33c27cb6cdfa1682585c9611251d8dcad5a7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
}, {
"hash" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931",
"triggerID" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"triggerType" : "PUSH"
}, {
"hash" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7935",
"triggerID" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"triggerType" : "PUSH"
}, {
"hash" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7940",
"triggerID" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"triggerType" : "PUSH"
}, {
"hash" : "7c8f33c27cb6cdfa1682585c9611251d8dcad5a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8143",
"triggerID" : "7c8f33c27cb6cdfa1682585c9611251d8dcad5a7",
"triggerType" : "PUSH"
}, {
"hash" : "f519b87c25d5a528e7db19e3fffbc2e097bd4772",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "716506904",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "716506904",
"triggerType" : "MANUAL"
}, {
"hash" : "f519b87c25d5a528e7db19e3fffbc2e097bd4772",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f519b87c25d5a528e7db19e3fffbc2e097bd4772",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* f519b87c25d5a528e7db19e3fffbc2e097bd4772 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
}, {
"hash" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931",
"triggerID" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"triggerType" : "PUSH"
}, {
"hash" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7935",
"triggerID" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"triggerType" : "PUSH"
}, {
"hash" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7940",
"triggerID" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"triggerType" : "PUSH"
}, {
"hash" : "7c8f33c27cb6cdfa1682585c9611251d8dcad5a7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8143",
"triggerID" : "7c8f33c27cb6cdfa1682585c9611251d8dcad5a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c8f33c27cb6cdfa1682585c9611251d8dcad5a7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8143)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas removed a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-712780047
@aljoscha ,thanks for your detailed explanation. Please review this pull requests again if you are available. Thanks very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711875185
@aljoscha Please help to review this pull request if you are available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
}, {
"hash" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931",
"triggerID" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"triggerType" : "PUSH"
}, {
"hash" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7935",
"triggerID" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"triggerType" : "PUSH"
}, {
"hash" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7940",
"triggerID" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97bc6647345b7c4b5b2a85c81a9f0f9052d37d88 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7935)
* 80e2c4e0a1fff42e9c2d2798ed7884a148870ee5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7940)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-716506904
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 55b7593928c1e8b4103cc12ae87f9580ef33f06c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804)
* 0e96b1f432be1a43daee779a11fe2cf680580068 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
}, {
"hash" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931",
"triggerID" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"triggerType" : "PUSH"
}, {
"hash" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7935",
"triggerID" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"triggerType" : "PUSH"
}, {
"hash" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7940",
"triggerID" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"triggerType" : "PUSH"
}, {
"hash" : "7c8f33c27cb6cdfa1682585c9611251d8dcad5a7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8143",
"triggerID" : "7c8f33c27cb6cdfa1682585c9611251d8dcad5a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 80e2c4e0a1fff42e9c2d2798ed7884a148870ee5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7940)
* 7c8f33c27cb6cdfa1682585c9611251d8dcad5a7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8143)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
}, {
"hash" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931",
"triggerID" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"triggerType" : "PUSH"
}, {
"hash" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7935",
"triggerID" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"triggerType" : "PUSH"
}, {
"hash" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7940",
"triggerID" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dca4699aaba410b65186c7ae688d6e47f44ffaaf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931)
* 97bc6647345b7c4b5b2a85c81a9f0f9052d37d88 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7935)
* 80e2c4e0a1fff42e9c2d2798ed7884a148870ee5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7940)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e96b1f432be1a43daee779a11fe2cf680580068 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha closed pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #13676:
URL: https://github.com/apache/flink/pull/13676
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-716496084
@SteNicholas Thanks for your work! I pushed some changes to your branch, I hope that's ok. I split the unrelated changes that remove imports. I also fixed the `PatternStreamBuilder`, the problem with the code before was that the time characteristic would be dropped when calling the builder methods that don't call the right constructor. And I changed `DataStreamMatch` to use an explicit type instead of a boolean, because it's hard to parse what they mean when looking at the code in passing.
Please let me know if you're ok with the changed, then I'd merge once CI is green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-716508117
Ah sorry, your other changes took very good. The API is very clean now. 👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
}, {
"hash" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931",
"triggerID" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dca4699aaba410b65186c7ae688d6e47f44ffaaf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas removed a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-712732952
@aljoscha ,thanks for your detailed explanation. Please help to review this pull requests again if you are available. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-711145212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7804",
"triggerID" : "55b7593928c1e8b4103cc12ae87f9580ef33f06c",
"triggerType" : "PUSH"
}, {
"hash" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7818",
"triggerID" : "0e96b1f432be1a43daee779a11fe2cf680580068",
"triggerType" : "PUSH"
}, {
"hash" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7822",
"triggerID" : "04b5e6bc606ef9f43205e3f521ab634ee7de5172",
"triggerType" : "PUSH"
}, {
"hash" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7931",
"triggerID" : "dca4699aaba410b65186c7ae688d6e47f44ffaaf",
"triggerType" : "PUSH"
}, {
"hash" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7935",
"triggerID" : "97bc6647345b7c4b5b2a85c81a9f0f9052d37d88",
"triggerType" : "PUSH"
}, {
"hash" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7940",
"triggerID" : "80e2c4e0a1fff42e9c2d2798ed7884a148870ee5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 80e2c4e0a1fff42e9c2d2798ed7884a148870ee5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7940)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org