You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/01/06 10:53:59 UTC
[GitHub] [orc] dongjoon-hyun opened a new pull request #608: ORC-711: Support LoadBalancingKMSClientProvider
dongjoon-hyun opened a new pull request #608:
URL: https://github.com/apache/orc/pull/608
### What changes were proposed in this pull request?
This PR aims to support `LoadBalancingKMSClientProvider` as a key provider.
### Why are the changes needed?
When `LoadBalancingKMSClientProvider` is used as a `KeyProvider`, `ClassCastException` occurs currently.
```java
public class LoadBalancingKMSClientProvider extends KeyProvider implements
CryptoExtension,
KeyProviderDelegationTokenExtension.DelegationTokenExtension {
```
### How was this patch tested?
Manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #608: ORC-711: Support LoadBalancingKMSClientProvider
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #608:
URL: https://github.com/apache/orc/pull/608#issuecomment-756464320
Could you review this, @omalley ? This is required to use Apache ORC with Hadoop 3.2 environment (for example, in Spark).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #608: ORC-711: Support LoadBalancingKMSClientProvider
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #608:
URL: https://github.com/apache/orc/pull/608#issuecomment-756464320
Could you review this, please, @omalley ? I noticed that this is required to use Apache ORC with Hadoop 3.2 environment (for example, in Spark). For Hadoop 2.8~2.10 environment, I don't know the behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #608: ORC-711: Support LoadBalancingKMSClientProvider
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #608:
URL: https://github.com/apache/orc/pull/608#issuecomment-755258292
Could you review this, @omalley and @pgaref ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #608: ORC-711: Support CryptoExtension in create/decryptLocalKey
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #608:
URL: https://github.com/apache/orc/pull/608#issuecomment-757522914
Late +1 from my side! Thanks @dongjoon-hyun !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #608: ORC-711: Support LoadBalancingKMSClientProvider
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #608:
URL: https://github.com/apache/orc/pull/608#issuecomment-756464320
Could you review this, please, @omalley ? This is required to use Apache ORC with Hadoop 3.2 environment (for example, in Spark).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #608: ORC-711: Support CryptoExtension in create/decryptLocalKey
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #608:
URL: https://github.com/apache/orc/pull/608
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #608: ORC-711: Support CryptoExtension in create/decryptLocalKey
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #608:
URL: https://github.com/apache/orc/pull/608#issuecomment-757523944
Thank you so much, @pgaref !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org