You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jpuerto <gi...@git.apache.org> on 2014/06/12 13:48:46 UTC
[GitHub] cordova-plugin-file-transfer pull request: CB-6928: Implements NOT...
GitHub user jpuerto opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/31
CB-6928: Implements NOT_MODIFIED check downloading resources.
As described in the issue https://issues.apache.org/jira/browse/CB-6928
A 304 status code will corrupt the transferred resource. This patch checks the status code and if the resource is cached, return as success with no actions.
I've move also the OutputStream declaration to use only if it's necessary and avoid unnecessary extra close method call.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpuerto/cordova-plugin-file-transfer master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit 74709aaf12c919400a6ca24862b8598cefc1ce80
Author: Javier Puerto <ja...@becompany.ch>
Date: 2014-06-12T08:34:42Z
CB-6928: Open output stream only if it's necessary.
commit b7a03c210dc592f2052a45272fd123e77d3d2e67
Author: Javier Puerto <ja...@becompany.ch>
Date: 2014-06-12T08:46:34Z
CB-6928: Implements NOT_MODIFIED check downloading resources.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file-transfer pull request: CB-6928: Implements NOT...
Posted by jpuerto <gi...@git.apache.org>.
Github user jpuerto commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/31#issuecomment-46279769
As commented in the dev mailing list, this patch is not valid. We need to return the caching status with the error callback so the developer can act accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file-transfer pull request: CB-6928: Implements NOT...
Posted by jpuerto <gi...@git.apache.org>.
Github user jpuerto closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---