You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/21 11:26:15 UTC
[GitHub] [airflow] potiuk opened a new pull request #15470: Fixes constraint generation for pypi providers
potiuk opened a new pull request #15470:
URL: https://github.com/apache/airflow/pull/15470
The constraints generated from PyPI version of providers, missed
core requirements of Airflow, therefore the constraints were not
consistent with setup.py core requirements.
Fixes: #15463
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15470: Fixes constraint generation for pypi providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15470:
URL: https://github.com/apache/airflow/pull/15470#issuecomment-823991781
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #15470: Fixes constraint generation for pypi providers
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #15470:
URL: https://github.com/apache/airflow/pull/15470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #15470: Fixes constraint generation for pypi providers
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15470:
URL: https://github.com/apache/airflow/pull/15470#discussion_r617451613
##########
File path: scripts/in_container/_in_container_utils.sh
##########
@@ -318,6 +318,7 @@ function install_local_airflow_with_eager_upgrade() {
function install_all_providers_from_pypi_with_eager_upgrade() {
+ NO_PROVIDERS_EXTRAS=$(python -c 'import setup; print(",".join(setup.CORE_EXTRAS_REQUIREMENTS.keys()))')
Review comment:
```suggestion
NO_PROVIDERS_EXTRAS=$(python -c 'import setup; print(",".join(setup.CORE_EXTRAS_REQUIREMENTS))')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org