You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/17 09:24:23 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4475: Fix: Data migration
Pearl1594 opened a new pull request #4475:
URL: https://github.com/apache/cloudstack/pull/4475
### Description
This PR fixes a regression that was caused due to the following commit: https://github.com/apache/cloudstack/commit/d864e9dc39b69e590e3df898a03a874a8173fcc6 - which reverted the handler for data migration introduced by #4053.
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [X] Major
- [ ] Minor
#### Bug Severity
- [X] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### How Has This Been Tested?
Performed data migration operation and verified the behavior - performed against all hypervisors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4475: Fix: Data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4475:
URL: https://github.com/apache/cloudstack/pull/4475#issuecomment-728813213
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4475: Fix: Data migration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4475:
URL: https://github.com/apache/cloudstack/pull/4475#issuecomment-729014328
> > I'm referring to the commit that caused the regression, @rhtyd . it has about 6000 lines changed in 127 files. this is the second regression due to that one.
>
> @DaanHoogland hope there is no more regression.
> by the way. is 4.15 LTS ?
I'm actually not sure. It is not added to https://cwiki.apache.org/confluence/display/CLOUDSTACK/LTS yet. @PaulAngus 4.15 is supposed to be an LTS release is it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4475: Fix: Data migration
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4475:
URL: https://github.com/apache/cloudstack/pull/4475
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4475: Fix: Data migration
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4475:
URL: https://github.com/apache/cloudstack/pull/4475#issuecomment-728847732
@DaanHoogland I only see 20 line changes
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4475: Fix: Data migration
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4475:
URL: https://github.com/apache/cloudstack/pull/4475#issuecomment-728853382
@DaanHoogland I could only identify the changes that we made by me that got reverted by the commit - __mainly__ the FSM changes in VolumeObject class and the handler in the BaseImageStoreDriverImpl class were the major breaking reverts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4475: Fix: Data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4475:
URL: https://github.com/apache/cloudstack/pull/4475#issuecomment-729217111
<b>Trillian test result (tid-3185)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35365 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4475-t3185-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 238.00 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4475: Fix: Data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4475:
URL: https://github.com/apache/cloudstack/pull/4475#issuecomment-729179816
<b>Trillian test result (tid-3184)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32596 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4475-t3184-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_scale_vm | `Failure` | 10.39 | test_scale_vm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4475: Fix: Data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4475:
URL: https://github.com/apache/cloudstack/pull/4475#issuecomment-728848120
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4475: Fix: Data migration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4475:
URL: https://github.com/apache/cloudstack/pull/4475#issuecomment-728859120
I'm referring to the commit that caused the regression, @rhtyd . it has about 6000 lines changed in 127 files. this is the second regression due to that one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4475: Fix: Data migration
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4475:
URL: https://github.com/apache/cloudstack/pull/4475#issuecomment-729009946
> I'm referring to the commit that caused the regression, @rhtyd . it has about 6000 lines changed in 127 files. this is the second regression due to that one.
@DaanHoogland hope there is no more regression.
by the way. is 4.15 LTS ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4475: Fix: Data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4475:
URL: https://github.com/apache/cloudstack/pull/4475#issuecomment-728840125
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2389
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4475: Fix: Data migration
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4475:
URL: https://github.com/apache/cloudstack/pull/4475#issuecomment-728812605
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4475: Fix: Data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4475:
URL: https://github.com/apache/cloudstack/pull/4475#issuecomment-729242341
<b>Trillian test result (tid-3186)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38595 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4475-t3186-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 787.57 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org