You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/06 10:27:29 UTC
[GitHub] [incubator-doris] BePPPower opened a new pull request, #9972: [feature] datetime column type support auto-initialized with default …
BePPPower opened a new pull request, #9972:
URL: https://github.com/apache/incubator-doris/pull/9972
…CURRENT_TIMESTAMP
# Proposed changes
Issue Number: close #9570
## Problem Summary:
An auto-initialized column is set to the current timestamp for inserted rows that specify no value for the column.
so when we define a column like sync_at DateTime DEFAULT CURRENT_TIMESTAMP COMMENT "sync time"
## Checklist(Required)
1. Does it affect the original behavior: (Yes)
2. Has unit tests been added: (No)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9972: [feature] datetime column type support auto-initialized with default …
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9972:
URL: https://github.com/apache/incubator-doris/pull/9972#issuecomment-1149828774
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9972: [feature] datetime column type support auto-initialized with default …
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #9972:
URL: https://github.com/apache/incubator-doris/pull/9972#discussion_r890086208
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java:
##########
@@ -315,8 +335,12 @@ public static void validateDefaultValue(Type type, String defaultValue) throws A
decimalLiteral.checkPrecisionAndScale(scalarType.getScalarPrecision(), scalarType.getScalarScale());
break;
case DATE:
+ DateLiteral dateLiteral = new DateLiteral(defaultValue, type);
+ break;
case DATETIME:
- new DateLiteral(defaultValue, type);
+ if (defaultValueExprDef == null || !defaultValueExprDef.getExprName().equals(DefaultValue.NOW)) {
+ DateLiteral datetimeLiteral = new DateLiteral(defaultValue, type);
Review Comment:
if defaultValueExprDef == null, then check datetimeLiteral
if defaultValueExprDef != null, then check the function name == now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9972: [feature] datetime column type support auto-initialized with default …
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #9972:
URL: https://github.com/apache/incubator-doris/pull/9972#discussion_r892010434
##########
regression-test/suites/correctness/test_current_timestamp.groovy:
##########
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+ // or more contributor license agreements. See the NOTICE file
+ // distributed with this work for additional information
+ // regarding copyright ownership. The ASF licenses this file
+ // to you under the Apache License, Version 2.0 (the
+ // "License"); you may not use this file except in compliance
+ // with the License. You may obtain a copy of the License at
+ //
+ // http://www.apache.org/licenses/LICENSE-2.0
+ //
+ // Unless required by applicable law or agreed to in writing,
+ // software distributed under the License is distributed on an
+ // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ // KIND, either express or implied. See the License for the
+ // specific language governing permissions and limitations
+ // under the License.
+
+suite("test_current_timestamp", "correctness") {
+ def tableName = "test_current_timestamp"
+
+ sql """ DROP TABLE IF EXISTS ${tableName} """
+ sql """
+ CREATE TABLE ${tableName}
+ (
+ id TINYINT,
+ name CHAR(10) NOT NULL DEFAULT "zs",
+ dt_0 DATETIME,
+ dt_1 DATETIME DEFAULT CURRENT_TIMESTAMP
+ )
+ COMMENT "test current_timestamp table"
+ DISTRIBUTED BY HASH(id)
+ PROPERTIES("replication_num" = "1");
+ """
+
+ // test insert into.
+ sql " insert into ${tableName} (id,name,dt_0) values (1,'aa',current_timestamp()); "
+ sql " insert into ${tableName} (id,name,dt_0) values (2,'bb',current_timestamp()); "
+ sql " insert into ${tableName} (id,name,dt_0) values (3,'cc',current_timestamp()); "
+ sql " insert into ${tableName} (id,name,dt_0) values (4,'dd',current_timestamp()); "
+
+ qt_insert_into """ select count(*) from ${tableName} where dt_0 = dt_1; """
Review Comment:
Do not compare date time, compare to_Date(dt_0) = to_date(dt_1), because date time is very accurate and the value maybe different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on pull request #9972: [feature] datetime column type support auto-initialized with default …
Posted by GitBox <gi...@apache.org>.
yiguolei commented on PR #9972:
URL: https://github.com/apache/incubator-doris/pull/9972#issuecomment-1147367508
Add regression test please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9972: [feature] datetime column type support auto-initialized with default …
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9972:
URL: https://github.com/apache/incubator-doris/pull/9972#issuecomment-1149828737
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9972: [feature] datetime column type support auto-initialized with default …
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9972:
URL: https://github.com/apache/incubator-doris/pull/9972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org