You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/03/13 14:26:58 UTC
[GitHub] [libcloud] c-w commented on pull request #1663: Authenticate with Azure Ad for Provider AZURE_BLOBS
c-w commented on pull request #1663:
URL: https://github.com/apache/libcloud/pull/1663#issuecomment-1066113567
Happy to take a look and thanks for the contribution! This is great. There
were a fair few times that I myself had to fall back to the first party SDK
due to lack of Azure AD auth so this will be a game changer.
Just a heads up: my baby daughter was born yesterday so life is a bit
hectic right now, but I’ll try to get to this ASAP.
On Sun, Mar 13, 2022 at 6:31 AM Codecov Comments Bot <
***@***.***> wrote:
> Codecov
> <https://codecov.io/gh/apache/libcloud/pull/1663?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation>
> Report
>
> Merging #1663
> <https://codecov.io/gh/apache/libcloud/pull/1663?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation>
> (ba4b21d
> <https://github.com/apache/libcloud/commit/ba4b21d11cac9da587bbdab94fdc06b879caa40a>)
> into trunk
> <https://codecov.io/gh/apache/libcloud/commit/d72d4a3328a443ead76ed3bc96ac9c83bbd41b06?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation>
> (d72d4a3
> <https://github.com/apache/libcloud/commit/d72d4a3328a443ead76ed3bc96ac9c83bbd41b06>)
> will *increase* coverage by 0.00%.
> The diff coverage is 89.32%.
>
> [image: Impacted file tree graph]
> <https://codecov.io/gh/apache/libcloud/pull/1663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation>
>
> @@ Coverage Diff @@
> ## trunk #1663 +/- ##
>
> =======================================
>
> Coverage 83.25% 83.25%
>
> =======================================
>
> Files 400 400
>
> Lines 87113 87211 +98
>
> Branches 9249 9257 +8
>
> =======================================
> + Hits 72524 72611 +87
> - Misses 11446 11451 +5
> - Partials 3143 3149 +6
>
> Impacted Files
> <https://codecov.io/gh/apache/libcloud/pull/1663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation> Coverage
> Δ
> libcloud/test/storage/test_azure_blobs.py
> <https://codecov.io/gh/apache/libcloud/pull/1663/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9zdG9yYWdlL3Rlc3RfYXp1cmVfYmxvYnMucHk=> 94.42%
> <86.20%> (-0.47%) ⬇️
> libcloud/common/azure.py
> <https://codecov.io/gh/apache/libcloud/pull/1663/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2F6dXJlLnB5> 85.81%
> <88.37%> (+1.04%) ⬆️
> libcloud/storage/drivers/azure_blobs.py
> <https://codecov.io/gh/apache/libcloud/pull/1663/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvc3RvcmFnZS9kcml2ZXJzL2F6dXJlX2Jsb2JzLnB5> 87.21%
> <93.54%> (+0.36%) ⬆️
> ------------------------------
>
> Continue to review full report at Codecov
> <https://codecov.io/gh/apache/libcloud/pull/1663?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation>
> .
>
> *Legend* - Click here to learn more
> <https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation>
> Δ = absolute <relative> (impact), ø = not affected, ? = missing data
> Powered by Codecov
> <https://codecov.io/gh/apache/libcloud/pull/1663?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation>.
> Last update d72d4a3...ba4b21d
> <https://codecov.io/gh/apache/libcloud/pull/1663?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation>.
> Read the comment docs
> <https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation>
> .
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/libcloud/pull/1663#issuecomment-1066071127>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAIJHVIMWSUQYVNR6LVHIITU7XGXRANCNFSM5QQXJC5A>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org