[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #607: feat(java/driver/jdbc): create AdbcDatabase from javax.sql.DataSource

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #607:
URL: https://github.com/apache/arrow-adbc/pull/607#discussion_r1177199192


##########
java/driver/jdbc-validation-derby/src/test/java/org/apache/arrow/adbc/driver/jdbc/derby/DerbyConnectionTest.java:
##########
@@ -28,4 +39,31 @@ public class DerbyConnectionTest extends AbstractConnectionTest {
   static void beforeAll() {
     quirks = new DerbyQuirks(tempDir);
   }
+
+  @Test
+  void newUrlOption() throws Exception {
+    try (final BufferAllocator allocator = new RootAllocator()) {
+      AdbcDriver driver = new JdbcDriver(allocator);
+      Map<String, Object> parameters = new HashMap<>();
+      parameters.put("url", "jdbc:derby:memory:newUrlOption;create=true");

Review Comment:
   Gah, I meant to have "uri" here yes. Thanks for catching me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org