You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Hequn Cheng (Jira)" <ji...@apache.org> on 2020/02/23 06:41:00 UTC
[jira] [Commented] (FLINK-16241) Remove the license and notice file
in flink-ml-lib module on release-1.10 branch
[ https://issues.apache.org/jira/browse/FLINK-16241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042811#comment-17042811 ]
Hequn Cheng commented on FLINK-16241:
-------------------------------------
There are two options to solve this problem:
1. Bundle the dependencies in the flink-ml-lib jar.
2. Remove the license and notice file.
Since it seems not good to add dependencies in a hotfix version, maybe it's better to remove the license and notice file directly(option 2).
What do you think? [~chesnay] [~rongr]
> Remove the license and notice file in flink-ml-lib module on release-1.10 branch
> --------------------------------------------------------------------------------
>
> Key: FLINK-16241
> URL: https://issues.apache.org/jira/browse/FLINK-16241
> Project: Flink
> Issue Type: Bug
> Components: Library / Machine Learning
> Affects Versions: 1.10.0
> Reporter: Hequn Cheng
> Assignee: Hequn Cheng
> Priority: Major
> Fix For: 1.10.1
>
>
> The jar of flink-ml-lib should not contain the license and notice file as it actually does not bundle the related dependencies. We should remove these file on branch release-1.10.
> BTW. The release-1.9 branch does not have this problem since the license and notice are added in 1.10. And on master(1.11), we will bundle the dependencies, so the license and notice file should be kept, see FLINK-15847.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)