You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dlab.apache.org by GitBox <gi...@apache.org> on 2020/07/07 13:16:44 UTC
[GitHub] [incubator-dlab] ppapou opened a new pull request #813: [DLAB-1921] Creation Group defect
ppapou opened a new pull request #813:
URL: https://github.com/apache/incubator-dlab/pull/813
- roleIds type has been changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ofuks merged pull request #813: [DLAB-1921] Creation Group defect
Posted by GitBox <gi...@apache.org>.
ofuks merged pull request #813:
URL: https://github.com/apache/incubator-dlab/pull/813
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ppapou commented on a change in pull request #813: [DLAB-1921] Creation Group defect
Posted by GitBox <gi...@apache.org>.
ppapou commented on a change in pull request #813:
URL: https://github.com/apache/incubator-dlab/pull/813#discussion_r451592274
##########
File path: services/self-service/src/test/java/com/epam/dlab/backendapi/resources/UserGroupResourceTest.java
##########
@@ -105,7 +105,7 @@ public void createGroupWhenRoleIdIsEmpty() {
.target("/group")
.request()
.header("Authorization", "Bearer " + TOKEN)
- .post(Entity.json(getCreateGroupDto(GROUP, Collections.emptySet())));
+ .post(Entity.json(getCreateGroupDto(GROUP, Collections.<String, String>emptyMap())));
Review comment:
The collection has been adjusted. Fix has been tested with creation, update and delete group actions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ofuks commented on a change in pull request #813: [DLAB-1921] Creation Group defect
Posted by GitBox <gi...@apache.org>.
ofuks commented on a change in pull request #813:
URL: https://github.com/apache/incubator-dlab/pull/813#discussion_r451343984
##########
File path: services/self-service/src/test/java/com/epam/dlab/backendapi/resources/UserGroupResourceTest.java
##########
@@ -105,7 +105,7 @@ public void createGroupWhenRoleIdIsEmpty() {
.target("/group")
.request()
.header("Authorization", "Bearer " + TOKEN)
- .post(Entity.json(getCreateGroupDto(GROUP, Collections.emptySet())));
+ .post(Entity.json(getCreateGroupDto(GROUP, Collections.<String, String>emptyMap())));
Review comment:
Can we use **Collections.emptyMap()** insead of **Collections.<String, String>emptyMap()**?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org