You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/03/19 22:24:36 UTC

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla

Hello Tim Armstrong, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12530

to look at the new patch set (#5).

Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla
......................................................................

IMPALA-8158: Retrieve thrift profiles through Impyla

This change uses an updated version of Impyla to retrieve thrift
profiles through the HS2 api. The companion change in Impyla is PR #333:
https://github.com/cloudera/impyla/pull/333

Unfortunately, some of the current usages of get_thrift_profile rely on
the Beeswax query states and the ImpylaHS2Connection does not have the
required functionality yet. We will have to update these in a future
change, once we unified the query states.

This change also adds a self-contained test for IMPALA-2063

Change-Id: I769a99f0843297dd2b20f2f5b1a9046c97bb131e
---
M tests/common/impala_connection.py
M tests/common/impala_service.py
M tests/common/impala_test_suite.py
M tests/query_test/test_cancellation.py
M tests/query_test/test_observability.py
5 files changed, 87 insertions(+), 85 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/12530/5
-- 
To view, visit http://gerrit.cloudera.org:8080/12530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I769a99f0843297dd2b20f2f5b1a9046c97bb131e
Gerrit-Change-Number: 12530
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>