You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by lg...@apache.org on 2007/10/08 18:17:28 UTC

svn commit: r582862 - /cocoon/trunk/blocks/cocoon-template/cocoon-template-impl/src/test/resources/org/apache/cocoon/template/jxtg/JXTemplateGeneratorTestCase.spring.xml

Author: lgawron
Date: Mon Oct  8 09:17:27 2007
New Revision: 582862

URL: http://svn.apache.org/viewvc?rev=582862&view=rev
Log:
use springified version of cocoon store

Modified:
    cocoon/trunk/blocks/cocoon-template/cocoon-template-impl/src/test/resources/org/apache/cocoon/template/jxtg/JXTemplateGeneratorTestCase.spring.xml

Modified: cocoon/trunk/blocks/cocoon-template/cocoon-template-impl/src/test/resources/org/apache/cocoon/template/jxtg/JXTemplateGeneratorTestCase.spring.xml
URL: http://svn.apache.org/viewvc/cocoon/trunk/blocks/cocoon-template/cocoon-template-impl/src/test/resources/org/apache/cocoon/template/jxtg/JXTemplateGeneratorTestCase.spring.xml?rev=582862&r1=582861&r2=582862&view=diff
==============================================================================
--- cocoon/trunk/blocks/cocoon-template/cocoon-template-impl/src/test/resources/org/apache/cocoon/template/jxtg/JXTemplateGeneratorTestCase.spring.xml (original)
+++ cocoon/trunk/blocks/cocoon-template/cocoon-template-impl/src/test/resources/org/apache/cocoon/template/jxtg/JXTemplateGeneratorTestCase.spring.xml Mon Oct  8 09:17:27 2007
@@ -32,13 +32,11 @@
   <import resource="classpath:META-INF/cocoon/spring/LegacyStringTemplateParser.xml" />
   <import resource="classpath:META-INF/cocoon/spring/ObjectModelTemplate.xml" />
   <import resource="classpath:META-INF/cocoon/spring/cocoon-template.xml" />
+
+  <import resource="classpath:META-INF/cocoon/spring/cocoon-thread-impl.xml" />
   <import resource="classpath:META-INF/cocoon/spring/cocoon-xml-impl.xml" />
+  <import resource="classpath:META-INF/cocoon/spring/cocoon-store-impl-janitor.xml" />
   <import resource="classpath:META-INF/cocoon/spring/cocoon-store-impl-transient.xml" />
-
-  <bean id="placeholderConfig" class="org.apache.cocoon.spring.configurator.impl.SettingsBeanFactoryPostProcessor"
-    init-method="init">
-    <property name="runningMode" value="dev" />
-  </bean>
 
   <bean name="org.apache.cocoon.el.objectmodel.ObjectModel"
     parent="org.apache.cocoon.el.objectmodel.ObjectModel.template" />



Re: svn commit: r582862 - /cocoon/trunk/blocks/cocoon-template/cocoon-template-impl/src/test/resources/org/apache/cocoon/template/jxtg/JXTemplateGeneratorTestCase.spring.xml

Posted by Leszek Gawron <lg...@mobilebox.pl>.
Grzegorz Kossakowski wrote:
> lgawron@apache.org pisze:
>> Author: lgawron
>> Date: Mon Oct  8 09:17:27 2007
>> New Revision: 582862
>>
>> URL: http://svn.apache.org/viewvc?rev=582862&view=rev
>> Log:
>> use springified version of cocoon store
> 
> Do you think we you need real implementation of store for testing?
> 
> What about using mock objects?


The store itself is not that heavy to mock it. Anyway the purpose of 
mocking IMO is:

- provide parts of the environment you do not have (http request, 
response, servlet context)
- test interaction between the tested component and it's dependencies 
(like testing if the cocoon template actually registers proper store 
entries).

It is way less important in this case to reduce dependencies as they are 
already in place. It's way easier to use store as it is than to create 
and debug a mock that provides a proper functionality.


-- 
Leszek Gawron                         http://www.mobilebox.pl/krs.html
CTO at MobileBox Ltd.


Re: svn commit: r582862 - /cocoon/trunk/blocks/cocoon-template/cocoon-template-impl/src/test/resources/org/apache/cocoon/template/jxtg/JXTemplateGeneratorTestCase.spring.xml

Posted by Grzegorz Kossakowski <gk...@apache.org>.
lgawron@apache.org pisze:
> Author: lgawron
> Date: Mon Oct  8 09:17:27 2007
> New Revision: 582862
> 
> URL: http://svn.apache.org/viewvc?rev=582862&view=rev
> Log:
> use springified version of cocoon store

Do you think we you need real implementation of store for testing?

What about using mock objects?

-- 
Grzegorz Kossakowski
Committer and PMC Member of Apache Cocoon
http://reflectingonthevicissitudes.wordpress.com/