You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "Dominique Pfister (JIRA)" <ji...@apache.org> on 2012/06/12 11:39:43 UTC
[jira] [Created] (OAK-138) Move client/server package in oak-mk to
separate project
Dominique Pfister created OAK-138:
-------------------------------------
Summary: Move client/server package in oak-mk to separate project
Key: OAK-138
URL: https://issues.apache.org/jira/browse/OAK-138
Project: Jackrabbit Oak
Issue Type: Improvement
Components: core, it, mk, run
Affects Versions: 0.3
Reporter: Dominique Pfister
Assignee: Dominique Pfister
As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.oak.mk.client and o.a.j.oak.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
This new project will then be added as a dependency to:
oak-core
oak-run
oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293787#comment-13293787 ]
Jukka Zitting commented on OAK-138:
-----------------------------------
> oak-mk contains one specific implementation of the MicroKernel API.
It also contains the MicroKernel API itself. As long as we don't want to split the API to a separate component, things like remoting IMHO fit best within that same component. Otherwise we have the troublesome situation where the remoting component depends on this specific implementation of the API. If we avoid the separate component, we only need to deal with package-level dependencies, where something like the .mk.server -> .mk.api dependency is perfectly fine.
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294428#comment-13294428 ]
Thomas Mueller commented on OAK-138:
------------------------------------
OK, my personal opinion is still to use as few projects as possible, but if everybody else things we need to do it then I can live with that.
We can later decide if we want to create additional projects for the data store implementation and the log wrapper.
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294318#comment-13294318 ]
Thomas Mueller commented on OAK-138:
------------------------------------
The data store that is currently in oak-mk (org.apache.jackrabbit.mk.blobs)
can be re-used in other mk implementations.
So I guess we should also create (at least) oak-mk-datastore or
oak-mk-blob. Similarly, the jsop part shouldn't be part of oak-mk.
We could move it to oak-commons or create a new project oak-commons-jsop.
I guess the same goes for the cache implementation (oak-commons or oak-commons-cache).
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293673#comment-13293673 ]
Thomas Mueller commented on OAK-138:
------------------------------------
I don't personally believe a separate Maven project for each MicroKernel implementation will simplify things. Instead of multiple packages, we have multiple projects. I would argue the complexity of multiple Maven projects is higher than the complexity of multiple packages. I don't see a big advantage for users either.
For Jackrabbit core, we have multiple persistence managers within jackrabbit-core, and I don't think this was actually confusing for anybody.
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Dominique Pfister (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294366#comment-13294366 ]
Dominique Pfister commented on OAK-138:
---------------------------------------
@Thomas: I agree that other MK implementations may benefit from such a refactoring into at least one project (e.g. oak-mk-commons or oak-mk-base). Nevertheless, this issue is about moving the remote classes into a separate project, as oak-mk does not depend on them (opposed to data store, jsop or cache), so IMHO this is a topic for another issue.
I think Jukka's right about the requirement for a separate MK API project, therefore:
+1 for oak-mk-remote
+1 for oak-mk-api
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OAK-138) Move client/server package in oak-mk to
separate project
Posted by "Dominique Pfister (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dominique Pfister updated OAK-138:
----------------------------------
Description:
As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
This new project will then be added as a dependency to:
oak-core
oak-run
oak-it-mk
was:
As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.oak.mk.client and o.a.j.oak.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
This new project will then be added as a dependency to:
oak-core
oak-run
oak-it-mk
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294393#comment-13294393 ]
Thomas Mueller commented on OAK-138:
------------------------------------
I understand this issue is about remoting. However, we should be consistent about when we create separate projects. So if we create separate projects for remoting and the MK API, then we should also create separate projects for many other components. The large project list above was only half joking - it was just the logical conclusion if we apply the same reasoning for separating the remoting implementation to other components. I personally don't want to go down that path, but if everybody agrees we need separate projects for things like the MK API, remoting (possibly multiple projects: client, server, commons), the log wrapper, then we would also separate projects for the data store (as it can be used in other MK implementations), and so on.
> alternative mk implementations require an explicit dependency on the 'default' implementation in oak-mk, including all transitive dependencies such as h2 etc. i find that weird.
Alternative MK implementations may want to re-use part of the data store implementation (the AbstractBlobStore, possibly the FileBlobStore and MemoryBlobStore). Therefore, for the same reason, the data store would need to be moved to a different project.
An alternative is to reduce the dependencies, for example make the dependency to H2 test only. It looks like the dependency is currently needed because the JdbcConnectionPool is used. Possibly we don't really need a connection pool (?) - in that case the dependency would not be needed.
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293674#comment-13293674 ]
angela commented on OAK-138:
----------------------------
+1 for a separate module for the mk-remoting. in my experience the remoting layers
require quite some additional dependencies that don't make any sense with the
mk implementation. similarly a non-remoting setup should be come with all that
additional stuff...
depending on how big that remoting gets i would even opt for splitting it in 2 separate
modules (client and the server part). for the time being we should at least
make sure that splitting later on was painless.
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294307#comment-13294307 ]
Stefan Guggisberg commented on OAK-138:
---------------------------------------
> It also contains the MicroKernel API itself. As long as we don't want to split the API to a separate component, things like remoting IMHO fit best within that same component.
my understanding was that we'll need to split the API to a separate component anyway sooner or later.
with the current setup alternative mk implementations require an explicit dependency on the 'default' implementation in oak-mk, including all transitive dependencies such as h2 etc. i find that weird.
IMHO an alternative mk implementation should only require a dependency on the MicroKernel API.
therefore,
+1 for oak-mk-remote
+1 for oak-mk-api
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293499#comment-13293499 ]
Thomas Mueller commented on OAK-138:
------------------------------------
The log wrapper is a somewhat similar implementation.
What about oak-mk-common, and use it for both the log wrapper and the remoting?
(possibly, if this will ever be needed, other implementations could be added, for example
a virtual repository wrapper which currently isn't needed).
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OAK-138) Move client/server package in oak-mk to
separate project
Posted by "Dominique Pfister (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dominique Pfister resolved OAK-138.
-----------------------------------
Resolution: Fixed
Added a separate oak-mk-api component, and refactored client/server to oak-mk-remote, as discussed.
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293842#comment-13293842 ]
Thomas Mueller commented on OAK-138:
------------------------------------
I'm wondering why we have so many Maven projects (and we get more and more) while Apache Lucene, Apache Derby, or Apache Tomcat have very few Maven projects. I just can't understand why.
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OAK-138) Move client/server package in
oak-mk to separate project
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294428#comment-13294428 ]
Thomas Mueller edited comment on OAK-138 at 6/13/12 12:59 PM:
--------------------------------------------------------------
OK, my personal opinion is still to use as few projects as possible, but if everybody else thinks we need to do it then I can live with that.
We can later decide if we want to create additional projects for the data store implementation, the log wrapper, and so on.
was (Author: tmueller):
OK, my personal opinion is still to use as few projects as possible, but if everybody else things we need to do it then I can live with that.
We can later decide if we want to create additional projects for the data store implementation and the log wrapper.
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293525#comment-13293525 ]
Felix Meschberger commented on OAK-138:
---------------------------------------
+1 to creating a separate module for remoting
-1 to merging with logging
Reason: Separation of concern through modularization.
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293666#comment-13293666 ]
Stefan Guggisberg commented on OAK-138:
---------------------------------------
> I'd rather just put the code to oak-mk as it's tightly bound to the MicroKernel interface.
oak-mk contains one specific implementation of the MicroKernel API.
the remoting code OTOH is generic and can be used with any mk implementation.
i'd prefer a separate module for the remoting layer instead of putting
everything mk-related into the current oak-mk module.
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293679#comment-13293679 ]
Thomas Mueller commented on OAK-138:
------------------------------------
Angela, so you would create 3 projects?
mk-remote-client
mk-remote-server
mk-remote-common
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293542#comment-13293542 ]
Thomas Mueller commented on OAK-138:
------------------------------------
I know Felix, you would create a separate Maven project. A project with one class.
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293623#comment-13293623 ]
Jukka Zitting commented on OAK-138:
-----------------------------------
I'd rather just put the code to oak-mk as it's tightly bound to the MicroKernel interface.
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293483#comment-13293483 ]
Stefan Guggisberg commented on OAK-138:
---------------------------------------
+1
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Dominique Pfister (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293559#comment-13293559 ]
Dominique Pfister commented on OAK-138:
---------------------------------------
-1 to merging as well: I prefer having an oak-mk-remote project with a concise name and a precise focus.
> The log wrapper is a somewhat similar implementation.
Hm, is there some other similarity besides that log wrapper and o.a.j.mk.client.Client both implement the MicroKernel interface?
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-138) Move client/server package in oak-mk
to separate project
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293855#comment-13293855 ]
Thomas Mueller commented on OAK-138:
------------------------------------
Some ideas about possible projects we could create:
- oak-commons-arrayutils
- oak-commons-pathutils
- oak-commons-stringutils
- oak-commons-ioutils
- oak-commons-jsop
- oak-commons-cache
- oak-core-api
- oak-core-spi
- oak-core-osgi
- oak-core-namepath
- oak-core-namespace
- oak-core-validater
- oak-core-security
- oak-core-state
- oak-core-query-api
- oak-core-query-impl
- oak-core-query-commons
- oak-core-query-spi
- oak-core-query-parser
- oak-jcr-api
- oak-jcr-security-api
- oak-jcr-security-impl
- oak-jcr-value
- oak-jcr-nodetype
- oak-jcr-osgi
- oak-jcr-xml
- oak-mk-api
- oak-mk-impl-inmemory
- oak-mk-impl-db
- oak-mk-impl-commons
- oak-mk-log-wrapper
- oak-mk-index-api
- oak-mk-index-impl
- oak-mk-index-commons
- oak-mk-virtual
- oak-mk-osgi
- oak-mk-datastore-api
- oak-mk-datastore-commons
- oak-mk-datastore-file
- oak-mk-datastore-db
- oak-mk-datastore-inmemory
- oak-mk-remote-server
- oak-mk-remote-client
- oak-mk-remote-commons
> Move client/server package in oak-mk to separate project
> --------------------------------------------------------
>
> Key: OAK-138
> URL: https://issues.apache.org/jira/browse/OAK-138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, it, mk, run
> Affects Versions: 0.3
> Reporter: Dominique Pfister
> Assignee: Dominique Pfister
>
> As a further cleanup step in OAK-13, I'd like to move the packages o.a.j.mk.client and o.a.j.mk.server and referenced classes in oak-mk to a separate project, e.g. oak-mk-remote.
> This new project will then be added as a dependency to:
> oak-core
> oak-run
> oak-it-mk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira