You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by dwimsey <gi...@git.apache.org> on 2015/11/19 03:49:08 UTC
[GitHub] storm pull request: MINOR: Use /usr/bin/env to find bash
GitHub user dwimsey opened a pull request:
https://github.com/apache/storm/pull/892
MINOR: Use /usr/bin/env to find bash
This is a minor change to the shell scripts in the bin directory that use bash which switches them to find bash via /usr/bin/env which should provide more cross platform compatibility. Specifically it will allow these scripts to work out of the box on the various BSDs with bash is installed in the default manner, in /usr/local/bin instead of /bin and should remain compatible with other OSes that typically put most things in /bin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dwimsey/storm feature/bash_env
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/892.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #892
----
commit a5ca650f7c94b07a46d3cb5a4f84ae893c83bb9c
Author: David Wimsey <dw...@chaos.wimsey.us>
Date: 2015-11-19T02:46:34Z
Switch to using /usr/bin/env bash instead of /bin/bash to find and execute bash in shell scripts to improve cross platform compatibility.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: MINOR: Use /usr/bin/env to find bash
Posted by hustfxj <gi...@git.apache.org>.
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/892#issuecomment-158260413
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: MINOR: Use /usr/bin/env to find bash
Posted by longdafeng <gi...@git.apache.org>.
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/892#issuecomment-158033245
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: MINOR: Use /usr/bin/env to find bash
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/892#issuecomment-159993926
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: MINOR: Use /usr/bin/env to find bash
Posted by lujinhong <gi...@git.apache.org>.
Github user lujinhong commented on the pull request:
https://github.com/apache/storm/pull/892#issuecomment-158262273
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: MINOR: Use /usr/bin/env to find bash
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/892#issuecomment-158126906
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: MINOR: Use /usr/bin/env to find bash
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/892
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: MINOR: Use /usr/bin/env to find bash
Posted by unsleepy22 <gi...@git.apache.org>.
Github user unsleepy22 commented on the pull request:
https://github.com/apache/storm/pull/892#issuecomment-158080086
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---