[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5784: Incorrect row comparison for tpch queries in benchmarks

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5784:
URL: https://github.com/apache/arrow-datafusion/pull/5784#discussion_r1153654461


##########
benchmarks/src/bin/tpch.rs:
##########
@@ -1118,6 +1118,20 @@ mod ci {
                             )
                         }
                     }
+                    (
+                        ScalarValue::Decimal128(Some(l), _, s),
+                        ScalarValue::Decimal128(Some(r), _, _),
+                    ) => {
+                        let tolerance = 0.1;

Review Comment:
   tolerance is already defined above in the `float` path -- maybe we could make it a constant or something. Very minor



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org