You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2012/09/02 00:13:07 UTC
[jira] [Created] (TOMAHAWK-1635) Allow 'long' values for maxSize
and maxFileSize configuration
Leonardo Uribe created TOMAHAWK-1635:
----------------------------------------
Summary: Allow 'long' values for maxSize and maxFileSize configuration
Key: TOMAHAWK-1635
URL: https://issues.apache.org/jira/browse/TOMAHAWK-1635
Project: MyFaces Tomahawk
Issue Type: Improvement
Components: File Upload
Reporter: Leonardo Uribe
Commons fileupload allow 'long' values, but tomahawk restrict them to 'int'. This is a common question and after all, it is up to the user to define how large is this param.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TOMAHAWK-1635) Allow 'long' values for maxSize
and maxFileSize configuration
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe reopened TOMAHAWK-1635:
--------------------------------------
Reopening, because the version of ExtensionsFilter located in 2.0 branch was not updated.
> Allow 'long' values for maxSize and maxFileSize configuration
> -------------------------------------------------------------
>
> Key: TOMAHAWK-1635
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1635
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: File Upload
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 1.1.14
>
>
> Commons fileupload allow 'long' values, but tomahawk restrict them to 'int'. This is a common question and after all, it is up to the user to define how large is this param.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TOMAHAWK-1635) Allow 'long' values for maxSize
and maxFileSize configuration
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492611#comment-13492611 ]
Leonardo Uribe commented on TOMAHAWK-1635:
------------------------------------------
Do you have the class and line number, so I can check the code and do the change for you?
> Allow 'long' values for maxSize and maxFileSize configuration
> -------------------------------------------------------------
>
> Key: TOMAHAWK-1635
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1635
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: File Upload
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 1.1.14
>
>
> Commons fileupload allow 'long' values, but tomahawk restrict them to 'int'. This is a common question and after all, it is up to the user to define how large is this param.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TOMAHAWK-1635) Allow 'long' values for maxSize
and maxFileSize configuration
Posted by "Alexander Vinnik (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492786#comment-13492786 ]
Alexander Vinnik commented on TOMAHAWK-1635:
--------------------------------------------
Apparently, this change did not make it into 1.1.14 that is available for download on http://myfaces.apache.org/tomahawk/download.html. The binary tomahawk20-1.1.14-bin.zip doesn't behave like the bug is fixed, and the source tomahawk20-1.1.14-src.zip still has int: tomahawk20-1.1.14-src.zip\tomahawk20-1.1.14\src\org\apache\myfaces\webapp\filter\ExtensionsFilter.java shows "private int _uploadMaxFileSize = 100 * 1024 * 1024;"
> Allow 'long' values for maxSize and maxFileSize configuration
> -------------------------------------------------------------
>
> Key: TOMAHAWK-1635
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1635
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: File Upload
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 1.1.14
>
>
> Commons fileupload allow 'long' values, but tomahawk restrict them to 'int'. This is a common question and after all, it is up to the user to define how large is this param.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TOMAHAWK-1635) Allow 'long' values for maxSize
and maxFileSize configuration
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492777#comment-13492777 ]
Leonardo Uribe commented on TOMAHAWK-1635:
------------------------------------------
It seems the site doc has not been updated. The code is at:
http://svn.apache.org/repos/asf/myfaces/tomahawk/trunk/
Check this link:
http://svn.apache.org/repos/asf/myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/webapp/filter/ExtensionsFilter.java
to see it more friendly:
http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/webapp/filter/ExtensionsFilter.java?view=markup
It has the change correctly applied.
> Allow 'long' values for maxSize and maxFileSize configuration
> -------------------------------------------------------------
>
> Key: TOMAHAWK-1635
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1635
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: File Upload
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 1.1.14
>
>
> Commons fileupload allow 'long' values, but tomahawk restrict them to 'int'. This is a common question and after all, it is up to the user to define how large is this param.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TOMAHAWK-1635) Allow 'long' values for maxSize
and maxFileSize configuration
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492804#comment-13492804 ]
Leonardo Uribe commented on TOMAHAWK-1635:
------------------------------------------
To be more specific, the file that needs to be updated was this:
http://svn.apache.org/repos/asf/myfaces/tomahawk/trunk/core20/src/main/java/org/apache/myfaces/webapp/filter/ExtensionsFilter.java
> Allow 'long' values for maxSize and maxFileSize configuration
> -------------------------------------------------------------
>
> Key: TOMAHAWK-1635
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1635
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: File Upload
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 1.1.15-SNAPSHOT
>
>
> Commons fileupload allow 'long' values, but tomahawk restrict them to 'int'. This is a common question and after all, it is up to the user to define how large is this param.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TOMAHAWK-1635) Allow 'long' values for maxSize
and maxFileSize configuration
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved TOMAHAWK-1635.
--------------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.1.14)
1.1.15-SNAPSHOT
I have fixed the problem, now it should work. Let us know if you have problems with it.
> Allow 'long' values for maxSize and maxFileSize configuration
> -------------------------------------------------------------
>
> Key: TOMAHAWK-1635
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1635
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: File Upload
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 1.1.15-SNAPSHOT
>
>
> Commons fileupload allow 'long' values, but tomahawk restrict them to 'int'. This is a common question and after all, it is up to the user to define how large is this param.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TOMAHAWK-1635) Allow 'long' values for maxSize
and maxFileSize configuration
Posted by "Alexander Vinnik (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492601#comment-13492601 ]
Alexander Vinnik commented on TOMAHAWK-1635:
--------------------------------------------
I downloaded 1.1.14, and it seems like this bug is not fixed there. maxUploadFileSize still overflows at 2GB (at 2GB it becomes 0 and rejects any upload), and looking at the source code, maxUploadFileSize is still an int and not long.
> Allow 'long' values for maxSize and maxFileSize configuration
> -------------------------------------------------------------
>
> Key: TOMAHAWK-1635
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1635
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: File Upload
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 1.1.14
>
>
> Commons fileupload allow 'long' values, but tomahawk restrict them to 'int'. This is a common question and after all, it is up to the user to define how large is this param.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TOMAHAWK-1635) Allow 'long' values for maxSize
and maxFileSize configuration
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved TOMAHAWK-1635.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.1.14-SNAPSHOT
Assignee: Leonardo Uribe
> Allow 'long' values for maxSize and maxFileSize configuration
> -------------------------------------------------------------
>
> Key: TOMAHAWK-1635
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1635
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: File Upload
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 1.1.14-SNAPSHOT
>
>
> Commons fileupload allow 'long' values, but tomahawk restrict them to 'int'. This is a common question and after all, it is up to the user to define how large is this param.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TOMAHAWK-1635) Allow 'long' values for maxSize
and maxFileSize configuration
Posted by "Alexander Vinnik (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492640#comment-13492640 ]
Alexander Vinnik commented on TOMAHAWK-1635:
--------------------------------------------
One place that I saw was in http://myfaces.apache.org/tomahawk-project/tomahawk/xref/org/apache/myfaces/webapp/filter/ExtensionsFilter.html, line 149. I would expect it to be long and not int.
> Allow 'long' values for maxSize and maxFileSize configuration
> -------------------------------------------------------------
>
> Key: TOMAHAWK-1635
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1635
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: File Upload
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 1.1.14
>
>
> Commons fileupload allow 'long' values, but tomahawk restrict them to 'int'. This is a common question and after all, it is up to the user to define how large is this param.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira