You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by xv...@apache.org on 2019/05/27 23:52:29 UTC

[incubator-druid] 01/02: Enable compiling against Java 9+ (tests disabled)

This is an automated email from the ASF dual-hosted git repository.

xvrl pushed a commit to branch compile-jdk11
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git

commit 57d075c58d05de7435e11e47c6b666991589a420
Author: Xavier Léauté <xv...@apache.org>
AuthorDate: Fri Apr 19 08:59:54 2019 -0700

    Enable compiling against Java 9+ (tests disabled)
    
    This change only enables compilation to ensure code compiles against
    recent Java versions going forward. Tests are still disabled in this
    profile until test failures are addressed.
---
 .travis.yml |  3 +++
 pom.xml     | 29 +++++++++++++++++++++++++++++
 2 files changed, 32 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 16c6d42..be35906 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -31,6 +31,9 @@ cache:
 
 matrix:
   include:
+      # Java 11 build
+    - jdk: openjdk11
+
       # license checks
     - env:
        - NAME="license checks"
diff --git a/pom.xml b/pom.xml
index ba9d713..50d39b7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -73,6 +73,7 @@
     <properties>
         <maven.compiler.source>1.8</maven.compiler.source>
         <maven.compiler.target>1.8</maven.compiler.target>
+        <java.version>8</java.version>
         <project.build.resourceEncoding>UTF-8</project.build.resourceEncoding>
         <apache.curator.version>4.1.0</apache.curator.version>
         <apache.curator.test.version>2.12.0</apache.curator.test.version>
@@ -1347,6 +1348,7 @@
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-compiler-plugin</artifactId>
+                    <version>3.8.0</version>
                     <configuration>
                         <source>${maven.compiler.source}</source>
                         <target>${maven.compiler.target}</target>
@@ -1367,6 +1369,33 @@
 
     <profiles>
         <profile>
+            <id>java-9+</id>
+            <activation>
+                <jdk>[9,)</jdk>
+            </activation>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-compiler-plugin</artifactId>
+                        <inherited>true</inherited>
+                        <!-- prefer release instead of source/target in JDK 9 and above -->
+                        <configuration>
+                            <release>${java.version}</release>
+                        </configuration>
+                    </plugin>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-surefire-plugin</artifactId>
+                        <configuration combine.self="override">
+                            <!-- disable tests until we fully support JDK 9 and above -->
+                            <skipTests>true</skipTests>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+        <profile>
             <id>strict</id>
             <build>
                 <plugins>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org