You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/06 09:37:59 UTC
[GitHub] [airflow] potiuk opened a new pull request, #24866: Add dependency of constraints on docs
potiuk opened a new pull request, #24866:
URL: https://github.com/apache/airflow/pull/24866
The dependency between constraints and docs jobs in CI were
missing and it led to Sphinx 5 breaking our main builds because
the constraints were updated even if the docs building failed
This change prevents similar case in the future - constraints
will not get updated if only docs build fails
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24866: Add dependency of constraints on docs
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24866:
URL: https://github.com/apache/airflow/pull/24866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24866: Add dependency of constraints on docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24866:
URL: https://github.com/apache/airflow/pull/24866#issuecomment-1176008597
Before we fix the docs - this is prevention from similar cases as we had tonight when updating to newer version of Sphinx broke our docs building for regular PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24866: Add dependency of constraints on docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24866:
URL: https://github.com/apache/airflow/pull/24866#issuecomment-1176091732
We should merge this one to prevent similar "doc buid due to constraints upgraded for sphinx only" cases happening in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org