You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by paulk-asert <gi...@git.apache.org> on 2015/07/30 14:46:46 UTC
[GitHub] incubator-groovy pull request: GROOVY-7529: Fix up transforms (apa...
GitHub user paulk-asert opened a pull request:
https://github.com/apache/incubator-groovy/pull/77
GROOVY-7529: Fix up transforms (apart from TupleConstructor) which ar…
…e affected by empty includes default
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/incubator-groovy groovy7529
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-groovy/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit d6f398b344a6cda38f319e061d0ab1257361c1c7
Author: paulk <pa...@asert.com.au>
Date: 2015-07-30T12:44:57Z
GROOVY-7529: Fix up transforms (apart from TupleConstructor) which are affected by empty includes default
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-groovy pull request: GROOVY-7529: Fix up transforms (apa...
Posted by paulk-asert <gi...@git.apache.org>.
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/77#discussion_r36029568
--- Diff: src/spec/doc/core-metaprogramming.adoc ---
@@ -966,6 +966,25 @@ include::{projectdir}/src/spec/test/CodeGenerationASTTransformsTest.groovy[tags=
----
|=======================================================================
+[[xform-MapConstructor]]
+===== @groovy.transform.MapConstructor
+
+The `@MapConstructor` annotation aims at eliminating boilerplate code by generating a map constructor for you. A map
--- End diff --
Yes, MapConstructor was missing from the documentation altogether. I added at least a placeholder but I'll probably try to add the doco in a separate commit and then rework this PR accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-groovy pull request: GROOVY-7529: Fix up transforms (apa...
Posted by paulk-asert <gi...@git.apache.org>.
Github user paulk-asert closed the pull request at:
https://github.com/apache/incubator-groovy/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-groovy pull request: GROOVY-7529: Fix up transforms (apa...
Posted by keeganwitt <gi...@git.apache.org>.
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/77#discussion_r35988461
--- Diff: src/spec/doc/core-metaprogramming.adoc ---
@@ -966,6 +966,25 @@ include::{projectdir}/src/spec/test/CodeGenerationASTTransformsTest.groovy[tags=
----
|=======================================================================
+[[xform-MapConstructor]]
+===== @groovy.transform.MapConstructor
+
+The `@MapConstructor` annotation aims at eliminating boilerplate code by generating a map constructor for you. A map
--- End diff --
Should this also have an attribute table like the other transformations?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---