You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/28 09:48:18 UTC

[GitHub] [kafka] see-quick commented on a diff in pull request #12692: MINOR: Add test cases to the Raft module

see-quick commented on code in PR #12692:
URL: https://github.com/apache/kafka/pull/12692#discussion_r982190906


##########
raft/src/main/java/org/apache/kafka/raft/VotedState.java:
##########
@@ -92,11 +92,6 @@ public boolean hasElectionTimeoutExpired(long currentTimeMs) {
         return electionTimer.isExpired();
     }
 
-    public void overrideElectionTimeout(long currentTimeMs, long timeoutMs) {

Review Comment:
   I will revert this method deletion and let only these test cases. Sounds good? I wonder if adding a test case for such an (un-used) method would be beneficial...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org