You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Sean Busbey (JIRA)" <ji...@apache.org> on 2015/05/08 18:43:00 UTC

[jira] [Updated] (HADOOP-11906) test-patch.sh should use 'file' command for patch determinism

     [ https://issues.apache.org/jira/browse/HADOOP-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Busbey updated HADOOP-11906:
---------------------------------
    Attachment: HADOOP-11906.1.patch

-01
  * "why not both?" - use {{file}} and fall back to first-line parsing.
  * If we think it's a patch but it's named wrong, give a warning on the jira and point them at the HowToContribute guide

> test-patch.sh should use 'file' command for patch determinism
> -------------------------------------------------------------
>
>                 Key: HADOOP-11906
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11906
>             Project: Hadoop Common
>          Issue Type: Test
>            Reporter: Allen Wittenauer
>            Assignee: Sean Busbey
>         Attachments: HADOOP-11906.1.patch
>
>
> test-patch.sh currently restricts patches to the extension .patch.  It might be useful to also check if the file command says it is a diff.  This would allow us to determine if files that end in .txt are actually patches.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)