[GitHub] [ozone] adoroszlai commented on a change in pull request #2996: HDDS-6194. EC: Freon ockg support EC write

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #2996:
URL: https://github.com/apache/ozone/pull/2996#discussion_r786967496



##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyGenerator.java
##########
@@ -66,23 +66,31 @@
       defaultValue = "4096")
   private int bufferSize;
 
-  @Option(names = { "-F", "--factor" },
-      description = "Replication factor (ONE, THREE)",
-      defaultValue = "THREE"
-  )
-  private ReplicationFactor factor = ReplicationFactor.THREE;
-

Review comment:
       It would be nice to keep the old option as `@Deprecated` for backward compatibility.  It should imply `--type RATIS`, and be mutually exclusive with `--replication`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org