You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/11/30 08:10:00 UTC
[jira] [Work logged] (KNOX-2095) Many errors (E.G. 504s) being masked as 500 errors
[ https://issues.apache.org/jira/browse/KNOX-2095?focusedWorklogId=687820&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687820 ]
ASF GitHub Bot logged work on KNOX-2095:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/21 08:09
Start Date: 30/Nov/21 08:09
Worklog Time Spent: 10m
Work Description: smolnar82 commented on pull request #177:
URL: https://github.com/apache/knox/pull/177#issuecomment-982381496
This PR has not been touched for over a year ago; closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 687820)
Remaining Estimate: 165h 10m (was: 165h 20m)
Time Spent: 2h 50m (was: 2h 40m)
> Many errors (E.G. 504s) being masked as 500 errors
> --------------------------------------------------
>
> Key: KNOX-2095
> URL: https://issues.apache.org/jira/browse/KNOX-2095
> Project: Apache Knox
> Issue Type: Improvement
> Affects Versions: 1.2.0, 1.3.0
> Reporter: James Chen
> Assignee: James Chen
> Priority: Minor
> Labels: easyfix
> Fix For: 1.6.0
>
> Attachments: KNOX-2095.patch, jamchen504patch.patch
>
> Original Estimate: 168h
> Time Spent: 2h 50m
> Remaining Estimate: 165h 10m
>
> When errors occur while accessing the Knox gateway, errors are forcibly overridden and represented as 500 errors, rather than whatever errors they should be.
> For example, when the timeout value under gateway.httpclient.socketTimeout is set to a very low timeout value (E.G. 1 ms) under gateway-site.xml, a socket timeout exception is produced by the getHttpClient().execute( outboundRequest) call. However, this is caught by the surrounding try-catch block and thrown again as an IOException. This results in a generic 500 error, rather than a 504 error one would normally expect from this sort of interaction.
>
> For these sorts of scenarios, I believe it would be prudent to create a dummy HttpResponse using a HttpResponseFactory object for the inboundResponse with the corresponding error code (E.G. HttpStatus.SC_GATEWAY_TIMEOUT in the event of a SocketTimeoutException) and return that instead to trigger the appropriate 504 error. I suspect there are other sorts of potential error code triggers that get this same IOException treatment that would be better off receiving their own error codes.
>
> Judging from the source code, this issue likely affects version 1.3.0, though this has not been tested.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)